Accessibility: Fix color enhancer disable option

Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521
Review-Url: https://codereview.chromium.org/2771613002
Cr-Commit-Position: refs/heads/master@{#459872}
Committed: https://chromium.googlesource.com/chromium/src/+/c84e01bfb9b85b7703d00d9a27a57a792179f215

[Peter Wen, 2017-03-22 20:46:40]

wnwen@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Peter Wen, 2017-03-22 20:46:40]

This should at least allow the extension to be usable again, just disable on
gmail and calendar, etc.

Somehow high contrast works with this exact design, so maybe there's a problem
in Blink for feColorMatrix? That's the only difference I can see between the
current public high contrast and color enhancer.

[dmazzoni, 2017-03-24 21:30:26]

Let's not disable it on certain sites. I'm sure
it's possible to get it to work.

I'm afraid I misled you because the code review I
had up was incomplete. I just sent you the correct
one - once you apply the fixed positioning I think
that should fix the color enhancer too.

Let me know if you still can't get it to work.

[Peter Wen, 2017-03-27 17:19:03]

Description was changed from

==========
Accessibility: Disable removes extension filter

Color enhancer extension should be completely disabled on certain
websites that it doesn't work on (gmail, calendar), and generally
wherever the user doesn't want it.

BUG=701521
==========

to

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

BUG=701521
==========

[Peter Wen, 2017-03-27 17:19:41]

Description was changed from

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

BUG=701521
==========

to

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521
==========

[Peter Wen, 2017-03-27 17:21:07]

PTAL with the updated description. I'll work on a separate CL to fix the root
cause, thanks!

My original description was wrong. This CL only fixes the existing disable
option, so users no longer have to uninstall the extension when they only want
to temporarily disable it.

[dmazzoni, 2017-03-27 17:28:54]

lgtm

[Peter Wen, 2017-03-27 17:38:58]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-03-27 17:39:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-03-27 17:52:15]

Description was changed from

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521
==========

to

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521
==========

[commit-bot: I haz the power, 2017-03-27 19:39:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:39:46]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Peter Wen, 2017-03-27 19:52:13]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-03-27 19:52:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 20:52:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490644333700100, "parent_rev":
"44cce866bb03e9424ac86ac4cdff8500fd906567", "commit_rev":
"c84e01bfb9b85b7703d00d9a27a57a792179f215"}

[commit-bot: I haz the power, 2017-03-27 20:53:43]

Description was changed from

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521
==========

to

==========
Accessibility: Fix color enhancer disable option

Color enhancer extension should be completely disabled when the user
selects the option to disable it. Previously we used the identity matrix
instead, which can cause problems when there is a filter regression, and
users have to completely remove the extension and refresh.

Also align with the way high contrast is using filters and css.

BUG=701521

Review-Url: https://codereview.chromium.org/2771613002
Cr-Commit-Position: refs/heads/master@{#459872}
Committed:
https://chromium.googlesource.com/chromium/src/+/c84e01bfb9b85b7703d00d9a27a5...
==========

[commit-bot: I haz the power, 2017-03-27 20:53:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c84e01bfb9b85b7703d00d9a27a5...