Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2771603002: [WIP] Change DocumentMarkerController::add*Marker() methods to take an EphemeralRange (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index fd4724b8fff6eb83aaf51c9c840eda12565c157b..8d5ea15fea2c440234434bde4c366bb1ef8e0b8f 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -448,8 +448,8 @@ void InputMethodController::addCompositionUnderlines(
continue;
document().markers().addCompositionMarker(
- ephemeralLineRange.startPosition(), ephemeralLineRange.endPosition(),
- underline.color(), underline.thick(), underline.backgroundColor());
+ ephemeralLineRange, underline.color(), underline.thick(),
+ underline.backgroundColor());
}
}
@@ -695,8 +695,7 @@ void InputMethodController::setComposition(
if (underlines.isEmpty()) {
document().markers().addCompositionMarker(
- m_compositionRange->startPosition(), m_compositionRange->endPosition(),
- Color::black, false,
+ EphemeralRange(m_compositionRange), Color::black, false,
LayoutTheme::theme().platformDefaultCompositionBackgroundColor());
return;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698