Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2771563002:
Roll clang 296321:298539. (Closed)
|
Created:
3 years, 9 months ago by Nico Modified:
3 years, 8 months ago CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll clang 296321:298539.
Ran `tools/clang/scripts/upload_revision.py 298539`.
The roll makes the tsan runtime abort on RTLD_DEEPBIND,
so disable one test under tsan that used that.
BUG=703833, 705255
TBR=hans
Review-Url: https://codereview.chromium.org/2771563002
Cr-Commit-Position: refs/heads/master@{#459802}
Committed: https://chromium.googlesource.com/chromium/src/+/3b3794c961885d1c714213f751846e4539f04042
Patch Set 1 #Patch Set 2 : tsan #
Messages
Total messages: 26 (20 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + hans@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. ========== to ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. BUG=703833 ==========
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=705255 for the tsan failure. It's possible that the Right Fix is just to disable that test under tsan.
Description was changed from ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. BUG=703833 ========== to ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. The roll makes the tsan runtime abort on RTLD_DEEPBIND, so disable one test under tsan that used that. BUG=703833,705255 ==========
Description was changed from ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. The roll makes the tsan runtime abort on RTLD_DEEPBIND, so disable one test under tsan that used that. BUG=703833,705255 ========== to ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. The roll makes the tsan runtime abort on RTLD_DEEPBIND, so disable one test under tsan that used that. BUG=703833,705255 TBR=hans ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490625433236600,
"parent_rev": "1564fcc1b0cda0cb3a36b43b91bdd4fc1588ac63", "commit_rev":
"3b3794c961885d1c714213f751846e4539f04042"}
Message was sent while issue was closed.
Description was changed from ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. The roll makes the tsan runtime abort on RTLD_DEEPBIND, so disable one test under tsan that used that. BUG=703833,705255 TBR=hans ========== to ========== Roll clang 296321:298539. Ran `tools/clang/scripts/upload_revision.py 298539`. The roll makes the tsan runtime abort on RTLD_DEEPBIND, so disable one test under tsan that used that. BUG=703833,705255 TBR=hans Review-Url: https://codereview.chromium.org/2771563002 Cr-Commit-Position: refs/heads/master@{#459802} Committed: https://chromium.googlesource.com/chromium/src/+/3b3794c961885d1c714213f75184... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3b3794c961885d1c714213f75184...
Message was sent while issue was closed.
stgao@chromium.org changed reviewers: + stgao@chromium.org
Message was sent while issue was closed.
According to this culprit-finding try-job https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... , this CL is the culprit for the the reliable test failure PrintPreviewDestinationSearchTest.Select starting at https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2... I'm gonna to revert. If it doesn't work, I will reland
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2781143002/ by stgao@chromium.org. The reason for reverting is: According to this culprit-finding try-job https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... , this CL is the culprit for the the reliable test failure PrintPreviewDestinationSearchTest.Select starting at https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
