Use new Keychain intents added in Android O.

Use new Keychain intents added in Android O.

ACTION_STORAGE_CHANGED is too spammy and broadcasts on whenever we gain
access to a key in addition to losing access. This means that whenever
the user clicks an auth prompt, we get a notification to drop all
previous selections.

In Android O, the notification is split into finer-grained notifications
with details available to distinguish gaining and losing access. Use
these instead in O.

BUG=381912, 653245
Review-Url: https://codereview.chromium.org/2771543002
Cr-Commit-Position: refs/heads/master@{#459014}
Committed: https://chromium.googlesource.com/chromium/src/+/15710b44fb12849ae9f165bafb934287a349cde6

[davidben, 2017-03-22 19:16:05]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:16:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-03-22 19:19:35]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 19:19:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-03-22 19:20:23]

davidben@chromium.org changed reviewers:
+ svaldez@chromium.org, tedchoc@chromium.org

[davidben, 2017-03-22 19:20:24]

svaldez for //net review.
tedchoc for general Android stuff.

[svaldez, 2017-03-22 19:36:28]

lgtm

[Ted C, 2017-03-22 20:15:50]

lgtm

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
File net/android/java/src/org/chromium/net/X509Util.java (right):

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
net/android/java/src/org/chromium/net/X509Util.java:74: if
(intent.getAction().equals(ACTION_KEYCHAIN_CHANGED)
to pass along a nit that I got recently that I think is a good practice, I'd put
ACTION_KEYCHAIN_CHANGED.equals(intent.getAction()) as it is guaranteed to never
NPE.

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
net/android/java/src/org/chromium/net/X509Util.java:81: &&
!intent.getBooleanExtra(EXTRA_KEY_ACCESSIBLE, false)) {
I was going to suggest we use IntentUtils.safeGetBooleanExtra, but that is in
chrome/ so nvm there either :-/

[commit-bot: I haz the power, 2017-03-22 20:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 20:19:52]

Dry run: This issue passed the CQ dry run.

[davidben, 2017-03-22 20:44:04]

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
File net/android/java/src/org/chromium/net/X509Util.java (right):

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
net/android/java/src/org/chromium/net/X509Util.java:74: if
(intent.getAction().equals(ACTION_KEYCHAIN_CHANGED)
On 2017/03/22 20:15:49, Ted C wrote:
> to pass along a nit that I got recently that I think is a good practice, I'd
put
> ACTION_KEYCHAIN_CHANGED.equals(intent.getAction()) as it is guaranteed to
never
> NPE.

Done.

https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
net/android/java/src/org/chromium/net/X509Util.java:81: &&
!intent.getBooleanExtra(EXTRA_KEY_ACCESSIBLE, false)) {
On 2017/03/22 20:15:49, Ted C wrote:
> I was going to suggest we use IntentUtils.safeGetBooleanExtra, but that is in
> chrome/ so nvm there either :-/

Should we move it to base/, or does it not matter much?

[Ted C, 2017-03-23 03:42:13]

On 2017/03/22 20:44:04, davidben wrote:
>
https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
> File net/android/java/src/org/chromium/net/X509Util.java (right):
> 
>
https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
> net/android/java/src/org/chromium/net/X509Util.java:74: if
> (intent.getAction().equals(ACTION_KEYCHAIN_CHANGED)
> On 2017/03/22 20:15:49, Ted C wrote:
> > to pass along a nit that I got recently that I think is a good practice, I'd
> put
> > ACTION_KEYCHAIN_CHANGED.equals(intent.getAction()) as it is guaranteed to
> never
> > NPE.
> 
> Done.
> 
>
https://codereview.chromium.org/2771543002/diff/20001/net/android/java/src/or...
> net/android/java/src/org/chromium/net/X509Util.java:81: &&
> !intent.getBooleanExtra(EXTRA_KEY_ACCESSIBLE, false)) {
> On 2017/03/22 20:15:49, Ted C wrote:
> > I was going to suggest we use IntentUtils.safeGetBooleanExtra, but that is
in
> > chrome/ so nvm there either :-/
> 
> Should we move it to base/, or does it not matter much?

Shouldn't matter for this.  It worked before and it is more to deal with VIEW
intents
from other apps that are malformed.  This is from the platform so it "shouldn't"
happen.

If we do move it, we'll just do a sweeping update of the code base.

[davidben, 2017-03-23 06:33:41]

The CQ bit was checked by davidben@chromium.org

[davidben, 2017-03-23 06:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/2771543002/#ps40001
(title: "tedchoc comment")

[commit-bot: I haz the power, 2017-03-23 06:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 07:28:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490250821464460,
"parent_rev": "36eaaf4564675f6b0fb3f616f7d057999ec9e497", "commit_rev":
"15710b44fb12849ae9f165bafb934287a349cde6"}

[commit-bot: I haz the power, 2017-03-23 07:30:09]

Description was changed from

==========
Use new Keychain intents added in Android O.

ACTION_STORAGE_CHANGED is too spammy and broadcasts on whenever we gain
access to a key in addition to losing access. This means that whenever
the user clicks an auth prompt, we get a notification to drop all
previous selections.

In Android O, the notification is split into finer-grained notifications
with details available to distinguish gaining and losing access. Use
these instead in O.

BUG=381912,653245
==========

to

==========
Use new Keychain intents added in Android O.

ACTION_STORAGE_CHANGED is too spammy and broadcasts on whenever we gain
access to a key in addition to losing access. This means that whenever
the user clicks an auth prompt, we get a notification to drop all
previous selections.

In Android O, the notification is split into finer-grained notifications
with details available to distinguish gaining and losing access. Use
these instead in O.

BUG=381912,653245

Review-Url: https://codereview.chromium.org/2771543002
Cr-Commit-Position: refs/heads/master@{#459014}
Committed:
https://chromium.googlesource.com/chromium/src/+/15710b44fb12849ae9f165bafb93...
==========

[commit-bot: I haz the power, 2017-03-23 07:30:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15710b44fb12849ae9f165bafb93...