Add support for the Win10 SDK to the PE reader

Add support for the Win10 SDK to the PE reader.

Only unblock zap_timestamp.exe, there's more work to do to make the decomposer VS2017 friendly...

Review-Url: https://codereview.chromium.org/2771503005
Committed: https://github.com/google/syzygy/commit/7677dfdf22749ca5bfa5f1d433e339f898060009

[Sébastien Marchand, 2017-03-23 20:47:16]

Description was changed from

==========
Add support for the Win10 SDK to the PE reader
==========

to

==========
Add support for the Win10 SDK to the PE reader.

Only unblock zap_timestamp.exe, there's more work to do to make the decomposer
VS2017 friendly...
==========

[Sébastien Marchand, 2017-03-23 20:47:16]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org

[chrisha, 2017-03-23 20:53:32]

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_file_parser.cc
File syzygy/pe/pe_file_parser.cc (right):

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_file_parser.cc...
syzygy/pe/pe_file_parser.cc:1167: case kLoadConfigDirectorySizeNoCFG:
Should these be 100NoCFG and 100NoCodeIntegrity?

[Sébastien Marchand, 2017-03-23 20:56:43]

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_file_parser.cc
File syzygy/pe/pe_file_parser.cc (right):

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_file_parser.cc...
syzygy/pe/pe_file_parser.cc:1167: case kLoadConfigDirectorySizeNoCFG:
On 2017/03/23 20:53:32, chrisha wrote:
> Should these be 100NoCFG and 100NoCodeIntegrity?

It depends, 100NoCFG will also mean 81, so I've decided to omit the version
number in this case, not sure what's the best naming strategy is.

[chrisha, 2017-03-23 21:29:30]

lgtm with nits

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h
File syzygy/pe/pe_structs.h (right):

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h#newc...
syzygy/pe/pe_structs.h:85: kLoadConfigDirectorySizeNoCodeIntegrity =
I'd prefer two identical enums:

kLoadConfigDirectorySize81:
kLoadConfigDirectorySize100NoCodeIntegrity:

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h#newc...
syzygy/pe/pe_structs.h:89: kLoadConfigDirectorySizeNoCFG =
And kLoadConfigDirectorySize100NoCFG

This is more self-documenting.

[Sébastien Marchand, 2017-03-24 13:19:52]

Thanks, committing.

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h
File syzygy/pe/pe_structs.h (right):

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h#newc...
syzygy/pe/pe_structs.h:85: kLoadConfigDirectorySizeNoCodeIntegrity =
On 2017/03/23 21:29:29, chrisha wrote:
> I'd prefer two identical enums:
> 
> kLoadConfigDirectorySize81:
> kLoadConfigDirectorySize100NoCodeIntegrity:

Done.

https://codereview.chromium.org/2771503005/diff/1/syzygy/pe/pe_structs.h#newc...
syzygy/pe/pe_structs.h:89: kLoadConfigDirectorySizeNoCFG =
On 2017/03/23 21:29:30, chrisha wrote:
> And kLoadConfigDirectorySize100NoCFG
> 
> This is more self-documenting.

Done.

[Sébastien Marchand, 2017-03-24 13:19:55]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2017-03-24 13:19:56]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2771503005/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-03-24 13:20:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 13:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 13:35:36]

Try jobs failed on following builders:
  win_rel_try on master.tryserver.client.syzygy (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.syzygy/builders/win_rel_try/bui...)

[Sébastien Marchand, 2017-04-04 16:04:30]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:04:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:04:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491321870075650,
"parent_rev": "56eca90183fcd7330109705ecd21963c70f832cf", "commit_rev":
"7677dfdf22749ca5bfa5f1d433e339f898060009"}

[commit-bot: I haz the power, 2017-04-04 16:04:58]

Description was changed from

==========
Add support for the Win10 SDK to the PE reader.

Only unblock zap_timestamp.exe, there's more work to do to make the decomposer
VS2017 friendly...
==========

to

==========
Add support for the Win10 SDK to the PE reader.

Only unblock zap_timestamp.exe, there's more work to do to make the decomposer
VS2017 friendly...

Review-Url: https://codereview.chromium.org/2771503005
Committed:
https://github.com/google/syzygy/commit/7677dfdf22749ca5bfa5f1d433e339f898060009
==========

[commit-bot: I haz the power, 2017-04-04 16:04:59]

Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/7677dfdf22749ca5bfa5f1d433e339f898060009