Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2771503004: [interpreter] Print bytecode handlers name with --trace-ignition-codegen (Closed)

Created:
3 years, 9 months ago by Pierre Langlois
Modified:
3 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Print bytecode handlers name with --trace-ignition-codegen When using --trace-ignition-codegen, the name for each bytecode handler is missing. The reason is that we find the name of a bytecode by looking up the code object entry in the interpreter's dispatch table, which is not yet populated at this point. BUG= Review-Url: https://codereview.chromium.org/2771503004 Cr-Commit-Position: refs/heads/master@{#44068} Committed: https://chromium.googlesource.com/v8/v8/+/cd78a32b62bcfa83b85a48cb3d1344f7667ced2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/interpreter/interpreter-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Pierre Langlois
3 years, 9 months ago (2017-03-23 14:34:32 UTC) #2
rmcilroy
LGTM, thanks.
3 years, 9 months ago (2017-03-23 14:49:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771503004/1
3 years, 9 months ago (2017-03-23 14:54:47 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 15:43:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd78a32b62bcfa83b85a48cb3d1344f7667...

Powered by Google App Engine
This is Rietveld 408576698