Fill in some necessary fields in web_view_url_request_context_getter to avoid crashes. Fixing this …

Fill in some fields in web_view_url_request_context_getter to fix crash.
Fixing this will allow the shell app to translate websites w/o issues.

BUG=698654
Review-Url: https://codereview.chromium.org/2771413002
Cr-Commit-Position: refs/heads/master@{#459992}
Committed: https://chromium.googlesource.com/chromium/src/+/0d1995f8a6a40a9ddc90d7d5aa86b9937d1ec426

[jzw, 2017-03-27 03:46:11]

jzw@google.com changed reviewers:
+ michaeldo@chromium.org

[michaeldo, 2017-03-27 05:37:43]

Thanks for fix! Please wrap CL description to 72 characters max line width and
take a look at one comment.

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_url_request_context_getter.mm (right):

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_url_request_context_getter.mm:109:
url_request_context_->transport_security_state(), base_path_,
Is there a reason to change this to use
|url_request_context_->transport_security_state()| instead of the same
transport_security_state passed to the storage object?

[jzw, 2017-03-27 07:53:34]

Description was changed from

==========
Fill in some necessary fields in web_view_url_request_context_getter to avoid
crashes. Fixing this will allow the shell app to translate websites w/o issues.

BUG=698654
==========

to

==========
Fill in some fields in web_view_url_request_context_getter to fix crash.
Fixing this will allow the shell app to translate websites w/o issues.

BUG=698654
==========

[jzw, 2017-03-27 09:04:40]

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_url_request_context_getter.mm (right):

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_url_request_context_getter.mm:109:
url_request_context_->transport_security_state(), base_path_,
On 2017/03/27 05:37:42, michaeldo wrote:
> Is there a reason to change this to use
> |url_request_context_->transport_security_state()| instead of the same
> transport_security_state passed to the storage object?

storage's set_transport_security_state calls std::move, which causes it that
unique_ptr to lose its content later on. but it turns out that method also sets
transport_security_state on the url_request_context, which is why i'm using it
here. i agree it does look a bit confusing, so if there's anyway i can make it
look better please let me know!

[michaeldo, 2017-03-27 23:03:46]

lgtm

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
File ios/web_view/internal/web_view_url_request_context_getter.mm (right):

https://codereview.chromium.org/2771413002/diff/1/ios/web_view/internal/web_v...
ios/web_view/internal/web_view_url_request_context_getter.mm:109:
url_request_context_->transport_security_state(), base_path_,
On 2017/03/27 09:04:40, jzw wrote:
> On 2017/03/27 05:37:42, michaeldo wrote:
> > Is there a reason to change this to use
> > |url_request_context_->transport_security_state()| instead of the same
> > transport_security_state passed to the storage object?
> 
> storage's set_transport_security_state calls std::move, which causes it that
> unique_ptr to lose its content later on. but it turns out that method also
sets
> transport_security_state on the url_request_context, which is why i'm using it
> here. i agree it does look a bit confusing, so if there's anyway i can make it
> look better please let me know!

I see thank you for the explanation. Your implementation makes sense in this
case, thanks!

[jzw, 2017-03-28 02:18:02]

The CQ bit was checked by jzw@google.com

[commit-bot: I haz the power, 2017-03-28 02:18:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:18:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490667482739070, "parent_rev":
"6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8", "commit_rev":
"0d1995f8a6a40a9ddc90d7d5aa86b9937d1ec426"}

[commit-bot: I haz the power, 2017-03-28 03:20:33]

Description was changed from

==========
Fill in some fields in web_view_url_request_context_getter to fix crash.
Fixing this will allow the shell app to translate websites w/o issues.

BUG=698654
==========

to

==========
Fill in some fields in web_view_url_request_context_getter to fix crash.
Fixing this will allow the shell app to translate websites w/o issues.

BUG=698654

Review-Url: https://codereview.chromium.org/2771413002
Cr-Commit-Position: refs/heads/master@{#459992}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d1995f8a6a40a9ddc90d7d5aa86...
==========

[commit-bot: I haz the power, 2017-03-28 03:20:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d1995f8a6a40a9ddc90d7d5aa86...