Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2771333002: Remove VS 2013 from vs_toolchain.py (Closed)

Created:
3 years, 9 months ago by brucedawson
Modified:
3 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VS 2013 from vs_toolchain.py Chrome has not built with VS 2013 for a while now, so no need to carry that baggage around as we add VS 2017 support. Review-Url: https://codereview.chromium.org/2771333002 Cr-Commit-Position: refs/heads/master@{#459876} Committed: https://chromium.googlesource.com/chromium/src/+/e7c0d998d5416b380ffefe1f6acd6126e35d11ed

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M build/vs_toolchain.py View 1 5 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
brucedawson
The sweet smell of code deletion
3 years, 9 months ago (2017-03-24 23:47:09 UTC) #6
scottmg
Good Riddance! lgtm https://codereview.chromium.org/2771333002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/2771333002/diff/1/build/vs_toolchain.py#newcode337 build/vs_toolchain.py:337: if env_version == '2017': Didn't this ...
3 years, 9 months ago (2017-03-25 00:12:29 UTC) #7
brucedawson
On 2017/03/25 00:12:29, scottmg wrote: > Good Riddance! lgtm > > https://codereview.chromium.org/2771333002/diff/1/build/vs_toolchain.py > File build/vs_toolchain.py ...
3 years, 9 months ago (2017-03-25 00:31:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771333002/20001
3 years, 9 months ago (2017-03-27 19:41:44 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 21:00:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7c0d998d5416b380ffefe1f6acd...

Powered by Google App Engine
This is Rietveld 408576698