Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: runtime/observatory/tests/service/service.status

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)
Patch Set: Removed garbage code, updated status file to skip service test not supported Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/service.status
diff --git a/runtime/observatory/tests/service/service.status b/runtime/observatory/tests/service/service.status
index 9c2039ed12386953f1cba2bba6c7ae1e569d9883..ddc8f0d6522c78134256ab29e538e854b5e5dfa9 100644
--- a/runtime/observatory/tests/service/service.status
+++ b/runtime/observatory/tests/service/service.status
@@ -99,6 +99,9 @@ step_through_getter_test: RuntimeError
dev_fs_weird_char_test: Skip # Windows disallows question mark in paths
dev_fs_http_put_weird_char_test: Skip # Windows disallows carriage returns in paths
+[ $system != linux && ($arch != x64 || $arch != ia32) ]
+get_native_allocation_samples_test: RuntimeError # Unsupported.
siva 2017/03/24 22:51:00 If it is not supported why not set the status to S
bkonyi 2017/03/27 17:50:25 You're right, that would make more sense. Using Ru
+
# Service protocol is not supported in product mode.
[ $mode == product ]
*: SkipByDesign

Powered by Google App Engine
This is Rietveld 408576698