runtime/observatory/tests/service/get_native_allocation_samples_test.dart - Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_native_allocation_samples_test.dart

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)

Patch Set: Removed garbage code, updated status file to skip service test not supported Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/tests/service/get_native_allocation_samples_test.dart

diff --git a/runtime/observatory/tests/service/get_native_allocation_samples_test.dart b/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

index f818aa8bda885ab2123af24b756fe1890fa671fd..ed76146fd090e34c0cd28d7736fa31b60df64f3f 100644

--- a/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

+++ b/runtime/observatory/tests/service/get_native_allocation_samples_test.dart

@@ -16,12 +16,6 @@ void verifyHelper(var root, bool exclusive) {

return;

}

-/* if (!(root is FunctionCallTreeNode)) {

- print('${root.profileCode.code.name}');

- } else {

- print('${root.profileFunction.function.name}');

- }

-*/

int inclusiveAllocations = 0;

int exclusiveAllocations = 0;

« no previous file with comments | « no previous file | runtime/observatory/tests/service/service.status » ('j') | runtime/observatory/tests/service/service.status » ('J')