Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: runtime/vm/malloc_hooks_test.cc

Issue 2771293003: Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st… (Closed)
Patch Set: Added page to Observatory to display native memory allocation information. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/malloc_hooks_mips.cc ('k') | runtime/vm/malloc_hooks_unsupported.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/malloc_hooks_test.cc
diff --git a/runtime/vm/malloc_hooks_test.cc b/runtime/vm/malloc_hooks_test.cc
index 834a340b8765e7a16dd12d1867aa1892602e8216..379ff5b1755ca3768d92ae4f7151943ab5f02de1 100644
--- a/runtime/vm/malloc_hooks_test.cc
+++ b/runtime/vm/malloc_hooks_test.cc
@@ -156,10 +156,14 @@ VM_UNIT_TEST_CASE(StackTraceMallocHookLengthTest) {
if (!(first_result && second_result)) {
OS::PrintErr(
"If this test is failing, it's likely that the value set for"
- "the number of frames to skip in malloc_hooks.cc is "
+ " the number of frames to skip in malloc_hooks.cc is "
"incorrect for this configuration/platform. This value can be"
" found in malloc_hooks.cc in the AllocationInfo class, and "
- "is stored in the kSkipCount constant.");
+ "is stored in the kSkipCount constant.\n");
+ OS::PrintErr("First result: %d Second Result: %d\n", first_result,
+ second_result);
+ OS::PrintErr("Dumping sample stack trace:\n");
+ sample->DumpStackTrace();
}
free(var);
« no previous file with comments | « runtime/vm/malloc_hooks_mips.cc ('k') | runtime/vm/malloc_hooks_unsupported.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698