Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and st…

runtime/vm/malloc_hooks_test.cc

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #if defined(DART_USE_TCMALLOC) && !defined(PRODUCT) &&                         \
     !defined(TARGET_ARCH_DBC) && !defined(HOST_OS_FUCHSIA)
 
 #include "platform/assert.h"
@@ skipping 138 matching lines @@
       (helper_start_address <= address) && (helper_end_address >= address);
   EXPECT(first_result);
   address = sample->At(1);
   bool second_result =
       (test_start_address <= address) && (test_end_address >= address);
   EXPECT(second_result);
 
   if (!(first_result && second_result)) {
     OS::PrintErr(
         "If this test is failing, it's likely that the value set for"
-        "the number of frames to skip in malloc_hooks.cc is "
+        " the number of frames to skip in malloc_hooks.cc is "
         "incorrect for this configuration/platform. This value can be"
         " found in malloc_hooks.cc in the AllocationInfo class, and "
-        "is stored in the kSkipCount constant.");
+        "is stored in the kSkipCount constant.\n");
+    OS::PrintErr("First result: %d Second Result: %d\n", first_result,
+                 second_result);
+    OS::PrintErr("Dumping sample stack trace:\n");
+    sample->DumpStackTrace();
   }
 
   free(var);
   MallocHooks::TearDown();
   MallocHooks::set_stack_trace_collection_enabled(enable_stack_traces_saved);
   FLAG_enable_malloc_hooks = enable_malloc_hooks_saved;
 }
 
 
 ISOLATE_UNIT_TEST_CASE(StackTraceMallocHookSimpleJSONTest) {
@@ skipping 27 matching lines @@
 
   free(var);
   MallocHooks::TearDown();
   MallocHooks::set_stack_trace_collection_enabled(enable_stack_traces_saved);
   FLAG_enable_malloc_hooks = enable_malloc_hooks_saved;
 }
 
 };  // namespace dart
 
 #endif  // defined(DART_USE_TCMALLOC) && !defined(PRODUCT)