Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2771283002: [Android] Record user actions of new context menus for CCT (Closed)

Created:
3 years, 9 months ago by ltian
Modified:
3 years, 9 months ago
Reviewers:
Ted C, jwd
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Android] Record user actions of new context menus for CCT Add the logic to record user actions for the newly added context menus ("Open in new Chrome tab", "Open in Chrome incognito tab", "Open in browser") for CCT. Also record the user action of "Open in Chrome" for Fullscreen mode. Change the title from "Open in Chrome incognito tab" to "Open in incognito tab" since the translation for the former one needs too much characters to show on the small screen devices. BUG=703426 NOTRY=true NOPRESUBMIT=true Original-Review-Url: https://codereview.chromium.org/2767703002 Original-Cr-Commit-Position: refs/heads/master@{#459178} (cherry picked from commit d8860857f5aa2a2a358c31c1122eccca7188faf9) Review-Url: https://codereview.chromium.org/2771283002 Cr-Commit-Position: refs/branch-heads/3029@{#428} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/40f4a7c18ed0ca2b713c273c612b713d9f7f1c4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ltian
tedchoc@chromium.org: could you lgtm this CL for merge to M58? Thanks!
3 years, 9 months ago (2017-03-24 19:14:45 UTC) #2
ltian
jwd@chromium.org: Sorry I am not a committer, so could you lgtm this CL to merge ...
3 years, 9 months ago (2017-03-24 19:15:41 UTC) #4
Ted C
lgtm
3 years, 9 months ago (2017-03-24 19:21:51 UTC) #5
jwd
lgtm
3 years, 9 months ago (2017-03-27 17:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771283002/1
3 years, 9 months ago (2017-03-27 17:40:52 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 17:50:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40f4a7c18ed0ca2b713c273c612b...

Powered by Google App Engine
This is Rietveld 408576698