[Android] Context menu and overflow item of CCT incorrect on Acer Predator when default browser is …

[Android] Context menu and overflow item of CCT incorrect on Acer Predator when default browser is set

When the default browser is selected, the overflow menu of CCT should
show "Open in [Default browser]" item and context menu should show "Open
in Chrome incognito tab" and "Open in new Chrome tab". While on Acer
Predator, items are still "Open in browser". This bug only happens on
Acer Predator.

It turns out that PackageMangaer on Acer Predator cannot find any package
which could resolve VIEW intent for HTTP sample url. To fix this, change
the sample url to HTTPS.

BUG=702795
Review-Url: https://codereview.chromium.org/2771173002
Cr-Commit-Position: refs/heads/master@{#460180}
Committed: https://chromium.googlesource.com/chromium/src/+/d9d08ba6477548fb48ce55cd1939b082d71b693c

[ltian, 2017-03-24 06:21:42]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-03-24 06:21:43]

tedchoc@chromium.org: could you take a look for my change in this CL?

Thanks!

[Ted C, 2017-03-28 17:10:12]

tedchoc@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Ted C, 2017-03-28 17:10:13]

lgtm (+maria for FYI)

[Maria, 2017-03-28 17:30:51]

On 2017/03/28 17:10:13, Ted C wrote:
> lgtm (+maria for FYI)

lgtm too. But wow that's weird -- how do they route http URLs on that device?!
What happens to links??

[ltian, 2017-03-28 17:56:00]

On 2017/03/28 17:30:51, Maria wrote:
> On 2017/03/28 17:10:13, Ted C wrote:
> > lgtm (+maria for FYI)
> 
> lgtm too. But wow that's weird -- how do they route http URLs on that device?!
> What happens to links??

I am not quite sure. When the url is HTTP, the ResolveInfo.match is always 0
even the default browser has been set. And ResolveInfo.loadLable return "Android
system". The way I figure out is because it is a regression bug and previous
code uses HTTPS.

[ltian, 2017-03-28 17:56:03]

On 2017/03/28 17:30:51, Maria wrote:
> On 2017/03/28 17:10:13, Ted C wrote:
> > lgtm (+maria for FYI)
> 
> lgtm too. But wow that's weird -- how do they route http URLs on that device?!
> What happens to links??

I am not quite sure. When the url is HTTP, the ResolveInfo.match is always 0
even the default browser has been set. And ResolveInfo.loadLable return "Android
system". The way I figure out is because it is a regression bug and previous
code uses HTTPS.

[ltian, 2017-03-28 17:56:11]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:50:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490723771912500, "parent_rev":
"a7c9f1ffb6bc4f554c4779e7b4bd19f8549de747", "commit_rev":
"d9d08ba6477548fb48ce55cd1939b082d71b693c"}

[commit-bot: I haz the power, 2017-03-28 18:51:42]

Description was changed from

==========
[Android] Context menu and overflow item of CCT incorrect on Acer Predator when
default browser is set

When the default browser is selected, the overflow menu of CCT should
show "Open in [Default browser]" item and context menu should show "Open
in Chrome incognito tab" and "Open in new Chrome tab". While on Acer
Predator, items are still "Open in browser". This bug only happens on
Acer Predator.

It turns out that PackageMangaer on Acer Predator cannot find any package
which could resolve VIEW intent for HTTP sample url. To fix this, change
the sample url to HTTPS.

BUG=702795
==========

to

==========
[Android] Context menu and overflow item of CCT incorrect on Acer Predator when
default browser is set

When the default browser is selected, the overflow menu of CCT should
show "Open in [Default browser]" item and context menu should show "Open
in Chrome incognito tab" and "Open in new Chrome tab". While on Acer
Predator, items are still "Open in browser". This bug only happens on
Acer Predator.

It turns out that PackageMangaer on Acer Predator cannot find any package
which could resolve VIEW intent for HTTP sample url. To fix this, change
the sample url to HTTPS.

BUG=702795

Review-Url: https://codereview.chromium.org/2771173002
Cr-Commit-Position: refs/heads/master@{#460180}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9d08ba6477548fb48ce55cd1939...
==========

[commit-bot: I haz the power, 2017-03-28 18:51:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9d08ba6477548fb48ce55cd1939...