Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2771073003: [heap] Perform filler check based on map instead of instance type in LiveObjectIterator. (Closed)

Created:
3 years, 9 months ago by Hannes Payer (out of office)
Modified:
3 years, 9 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Perform filler check based on map instead of instance type in LiveObjectIterator. BUG=v8:6139 Review-Url: https://codereview.chromium.org/2771073003 Cr-Commit-Position: refs/heads/master@{#44107} Committed: https://chromium.googlesource.com/v8/v8/+/9a3b029b6c8ccf3792f162c7f79ceacc694aa0df

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/heap/mark-compact-inl.h View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
lgtm
3 years, 9 months ago (2017-03-24 13:14:16 UTC) #4
ulan
lgtm https://codereview.chromium.org/2771073003/diff/1/src/heap/mark-compact-inl.h File src/heap/mark-compact-inl.h (right): https://codereview.chromium.org/2771073003/diff/1/src/heap/mark-compact-inl.h#newcode199 src/heap/mark-compact-inl.h:199: if (map == one_word_filler || map == two_word_filler ...
3 years, 9 months ago (2017-03-24 13:14:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771073003/20001
3 years, 9 months ago (2017-03-24 13:18:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:44:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9a3b029b6c8ccf3792f162c7f79ceacc694...

Powered by Google App Engine
This is Rietveld 408576698