Add missing files in //device to appropriate BUILD.gn files.

Add missing files in //device to appropriate BUILD.gn files.

This change makes sure that all source files under //device are listed
in a BUILD.gn file.

//device/serial/serial_service_unittest.cc is removed as it tests a Mojo
interface that no longer exists.

BUG=None

Review-Url: https://codereview.chromium.org/2771073002
Cr-Commit-Position: refs/heads/master@{#459250}
Committed: https://chromium.googlesource.com/chromium/src/+/aaee89102bcd2d5fbc90be61286297e391ef882a

[Reilly Grant (use Gerrit), 2017-03-23 18:04:04]

Rebased.

[Reilly Grant (use Gerrit), 2017-03-23 18:04:06]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[Reilly Grant (use Gerrit), 2017-03-23 18:04:36]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:04:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-03-23 18:04:37]

PTAL

[juncai, 2017-03-23 19:03:56]

LGTM with a nit.

https://codereview.chromium.org/2771073002/diff/20001/device/BUILD.gn
File device/BUILD.gn (right):

https://codereview.chromium.org/2771073002/diff/20001/device/BUILD.gn#newcode91
device/BUILD.gn:91: "//device/bluetooth/uribeacon",
nit: '/' is listed before ':' in the ASCII table, maybe this line should be
before:
"//device/bluetooth:mocks",

[Reilly Grant (use Gerrit), 2017-03-23 20:13:18]

https://codereview.chromium.org/2771073002/diff/20001/device/BUILD.gn
File device/BUILD.gn (right):

https://codereview.chromium.org/2771073002/diff/20001/device/BUILD.gn#newcode91
device/BUILD.gn:91: "//device/bluetooth/uribeacon",
On 2017/03/23 19:03:56, juncai wrote:
> nit: '/' is listed before ':' in the ASCII table, maybe this line should be
> before:
> "//device/bluetooth:mocks",

gn format recognizes that the : is a separator and sorts by the path first
before the target name.

[Reilly Grant (use Gerrit), 2017-03-23 20:13:24]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-03-23 20:13:26]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:13:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:20:17]

Failed to apply patch for device/power_save_blocker/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: device/power_save_blocker/BUILD.gn:13
  error: device/power_save_blocker/BUILD.gn: patch does not apply

Patch:       device/power_save_blocker/BUILD.gn
Index: device/power_save_blocker/BUILD.gn
diff --git a/device/power_save_blocker/BUILD.gn
b/device/power_save_blocker/BUILD.gn
index
0dfb683cb8773e351cc1c188b345261a862c403d..93e01d4a72e838284b309b3d38288dd1547417fd
100644
--- a/device/power_save_blocker/BUILD.gn
+++ b/device/power_save_blocker/BUILD.gn
@@ -13,7 +13,9 @@ component("power_save_blocker") {
   sources = [
     "power_save_blocker.h",
     "power_save_blocker_android.cc",
+    "power_save_blocker_android.h",
     "power_save_blocker_chromeos.cc",
+    "power_save_blocker_export.h",
     "power_save_blocker_mac.cc",
     "power_save_blocker_ozone.cc",
     "power_save_blocker_win.cc",

[Reilly Grant (use Gerrit), 2017-03-23 20:36:30]

Rebased.

[Reilly Grant (use Gerrit), 2017-03-23 20:37:00]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-03-23 20:37:01]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/2771073002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2017-03-23 20:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:16:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490301420884600,
"parent_rev": "cfb6ad6afbcbf21a718009d40895fbd7f33070ee", "commit_rev":
"aaee89102bcd2d5fbc90be61286297e391ef882a"}

[commit-bot: I haz the power, 2017-03-23 22:17:01]

Description was changed from

==========
Add missing files in //device to appropriate BUILD.gn files.

This change makes sure that all source files under //device are listed
in a BUILD.gn file.

//device/serial/serial_service_unittest.cc is removed as it tests a Mojo
interface that no longer exists.

BUG=None
==========

to

==========
Add missing files in //device to appropriate BUILD.gn files.

This change makes sure that all source files under //device are listed
in a BUILD.gn file.

//device/serial/serial_service_unittest.cc is removed as it tests a Mojo
interface that no longer exists.

BUG=None

Review-Url: https://codereview.chromium.org/2771073002
Cr-Commit-Position: refs/heads/master@{#459250}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaee89102bcd2d5fbc90be612862...
==========

[commit-bot: I haz the power, 2017-03-23 22:17:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aaee89102bcd2d5fbc90be612862...