Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2771063002: DevTools: make dropdown arrow spacing nicer (Closed)

Created:
3 years, 9 months ago by luoe
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make dropdown arrow spacing nicer This fixes a regression where the arrow was flush with the text. BUG=693016 Review-Url: https://codereview.chromium.org/2771063002 Cr-Commit-Position: refs/heads/master@{#459299} Committed: https://chromium.googlesource.com/chromium/src/+/9dd1eeaa4faec230139e1f70cbd0e4bbf959b177

Patch Set 1 #

Total comments: 2

Patch Set 2 : use triangle-down, remove dropdown-arrow icon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
luoe
Please take a look
3 years, 9 months ago (2017-03-23 20:18:23 UTC) #3
lushnikov
https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right): https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css#newcode58 third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:58: margin-left: 2px; while you're here, could you please re-use ...
3 years, 9 months ago (2017-03-23 20:56:24 UTC) #4
luoe
https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right): https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css#newcode58 third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:58: margin-left: 2px; On 2017/03/23 20:56:24, lushnikov wrote: > while ...
3 years, 9 months ago (2017-03-23 22:32:18 UTC) #5
lushnikov
lgtm
3 years, 9 months ago (2017-03-23 22:50:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771063002/20001
3 years, 9 months ago (2017-03-23 22:51:08 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 00:28:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9dd1eeaa4faec230139e1f70cbd0...

Powered by Google App Engine
This is Rietveld 408576698