DevTools: make dropdown arrow spacing nicer

DevTools: make dropdown arrow spacing nicer

This fixes a regression where the arrow was flush with the text.

BUG=693016
Review-Url: https://codereview.chromium.org/2771063002
Cr-Commit-Position: refs/heads/master@{#459299}
Committed: https://chromium.googlesource.com/chromium/src/+/9dd1eeaa4faec230139e1f70cbd0e4bbf959b177

[luoe, 2017-03-23 20:18:10]

Description was changed from

==========
DevTools: make dropdown arrow spacing nicer

BUG=693016
==========

to

==========
DevTools: make dropdown arrow spacing nicer

This fixes a regression where the arrow was flush with the text.

BUG=693016
==========

[luoe, 2017-03-23 20:18:23]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-03-23 20:18:23]

Please take a look

[lushnikov, 2017-03-23 20:56:24]

https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right):

https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:58: margin-left:
2px;
while you're here, could you please re-use the smallicon-triangle-down instead
of smallicon-dropdown-arrow?

[luoe, 2017-03-23 22:32:18]

https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/toolbar.css (right):

https://codereview.chromium.org/2771063002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/toolbar.css:58: margin-left:
2px;
On 2017/03/23 20:56:24, lushnikov wrote:
> while you're here, could you please re-use the smallicon-triangle-down instead
> of smallicon-dropdown-arrow?

Done.

[lushnikov, 2017-03-23 22:50:07]

lgtm

[lushnikov, 2017-03-23 22:50:14]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:51:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:27:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490309414883580,
"parent_rev": "088e4a90947078a9dd6db43a21770ad14d0b9e43", "commit_rev":
"9dd1eeaa4faec230139e1f70cbd0e4bbf959b177"}

[commit-bot: I haz the power, 2017-03-24 00:28:30]

Description was changed from

==========
DevTools: make dropdown arrow spacing nicer

This fixes a regression where the arrow was flush with the text.

BUG=693016
==========

to

==========
DevTools: make dropdown arrow spacing nicer

This fixes a regression where the arrow was flush with the text.

BUG=693016

Review-Url: https://codereview.chromium.org/2771063002
Cr-Commit-Position: refs/heads/master@{#459299}
Committed:
https://chromium.googlesource.com/chromium/src/+/9dd1eeaa4faec230139e1f70cbd0...
==========

[commit-bot: I haz the power, 2017-03-24 00:28:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9dd1eeaa4faec230139e1f70cbd0...