Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2771033005: Split out spdy_log_util from http_log_util. (Closed)

Created:
3 years, 9 months ago by Bence
Modified:
3 years, 9 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out spdy_log_util from http_log_util. Motivation: ElideHeaderValueForNetLog() is used in HttpRequestHeaders and HttpResponseHeaders, therefore must be included in a nacl build. On the other hand, ElideGoAwayDebugDataForNetLog() and ElideSpdyHeaderBlockForNetLog(), and their dependencies including SpdyHeaderBlock, UnsafeArena, and linked_hash_map, do not need to be included in a nacl build. This CL splits out these functions from http_log_util into spdy_log_util, and reverts the build changes that I made in https://crrev.com/2622703002. Also remove NetLogCaptureMode forward declaration: instances are passed by value, therefore declaration has to be included. Also use |auto headers_list = base::MakeUnique| instead of |unique_ptr headers_list(new)| in ElideSpdyHeaderBlockForNetLog(). Also add unittest for ElideSpdyHeaderBlockForNetLog(). Review-Url: https://codereview.chromium.org/2771033005 Cr-Commit-Position: refs/heads/master@{#459454} Committed: https://chromium.googlesource.com/chromium/src/+/4fab802da9defe20515b8da9ab72e9017bded970

Patch Set 1 #

Patch Set 2 : Remove http_log_util.h include from two files that do not use ElideHeaderValueForNetLog(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -85 lines) Patch
M net/BUILD.gn View 8 chunks +8 lines, -5 lines 0 comments Download
M net/http/bidirectional_stream.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_log_util.h View 2 chunks +1 line, -19 lines 0 comments Download
M net/http/http_log_util.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M net/http/http_log_util_unittest.cc View 2 chunks +1 line, -12 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A + net/spdy/spdy_log_util.h View 3 chunks +9 lines, -16 lines 0 comments Download
A net/spdy/spdy_log_util.cc View 1 chunk +40 lines, -0 lines 0 comments Download
A net/spdy/spdy_log_util_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Bence
xunjieli: PTAL. Thank you.
3 years, 9 months ago (2017-03-24 14:39:08 UTC) #4
xunjieli
On 2017/03/24 14:39:08, Bence wrote: > xunjieli: PTAL. Thank you. Nice change! The added unit ...
3 years, 9 months ago (2017-03-24 15:05:38 UTC) #5
Bence
On 2017/03/24 15:05:38, xunjieli wrote: > On 2017/03/24 14:39:08, Bence wrote: > > xunjieli: PTAL. ...
3 years, 9 months ago (2017-03-24 15:07:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771033005/20001
3 years, 9 months ago (2017-03-24 15:07:27 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 16:35:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4fab802da9defe20515b8da9ab72...

Powered by Google App Engine
This is Rietveld 408576698