Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2770983007: WebView: remove outdated docs for test shell (Closed)

Created:
3 years, 9 months ago by Nate Fischer
Modified:
3 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: update outdated docs for test shell WebView no longer supports the android_webview_apk target for anything other than automated testing. Keeping docs for building an unsupported target is misleading, especially since android_webview_apk is not actually a WebView. This CL keeps the description about WebView, but removes the parts about the test shell. It has a pointer to our team's chromium wiki page for building and installing AOSP WebView. This renames the section to "Build WebView" instead of "Build WebView shell" to reflect the update. BUG=703376 Review-Url: https://codereview.chromium.org/2770983007 Cr-Commit-Position: refs/heads/master@{#459221} Committed: https://chromium.googlesource.com/chromium/src/+/29a7adabb37e14293b305cc7d07aea54261d2ada

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add WebView description, rename section to "Build WebView", and adjust wording to refer to WebView … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M docs/android_build_instructions.md View 1 3 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nate Fischer
PTAL
3 years, 9 months ago (2017-03-23 20:29:29 UTC) #2
boliu
https://codereview.chromium.org/2770983007/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (left): https://codereview.chromium.org/2770983007/diff/1/docs/android_build_instructions.md#oldcode243 docs/android_build_instructions.md:243: If, instead, you want to build the complete Android ...
3 years, 9 months ago (2017-03-23 20:32:42 UTC) #3
Nate Fischer
https://codereview.chromium.org/2770983007/diff/1/docs/android_build_instructions.md File docs/android_build_instructions.md (left): https://codereview.chromium.org/2770983007/diff/1/docs/android_build_instructions.md#oldcode243 docs/android_build_instructions.md:243: If, instead, you want to build the complete Android ...
3 years, 9 months ago (2017-03-23 20:41:43 UTC) #4
boliu
lgtm
3 years, 9 months ago (2017-03-23 20:52:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770983007/20001
3 years, 9 months ago (2017-03-23 21:05:28 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 21:18:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/29a7adabb37e14293b305cc7d07a...

Powered by Google App Engine
This is Rietveld 408576698