Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2770963003: Remove OriginFilterBuilderTest. (Closed)

Created:
3 years, 9 months ago by msramek
Modified:
3 years, 9 months ago
Reviewers:
dvadym
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OriginFilterBuilderTest. The OriginFilterBuilder class was removed in https://codereview.chromium.org/2647683002, where this test was also removed from the build target, but the file was accidentally left in the codebase. The testcases from this file today live in BrowsingDataFilterBuilderTest. BUG=668114 Review-Url: https://codereview.chromium.org/2770963003 Cr-Commit-Position: refs/heads/master@{#459112} Committed: https://chromium.googlesource.com/chromium/src/+/143b4e10c91a42f3d43ca721b4ec137a2495c2e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -111 lines) Patch
D chrome/browser/browsing_data/origin_filter_builder_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
msramek
Hi Vadym! Can you please have a quick look? Thanks, Martin
3 years, 9 months ago (2017-03-23 15:51:37 UTC) #2
dvadym
LGTM
3 years, 9 months ago (2017-03-23 16:14:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770963003/1
3 years, 9 months ago (2017-03-23 16:17:01 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:34:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/143b4e10c91a42f3d43ca721b4ec...

Powered by Google App Engine
This is Rietveld 408576698