Include control clip in list of clip-related properties.

Include control clip in list of clip-related properties.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2770943003
Cr-Commit-Position: refs/heads/master@{#459407}
Committed: https://chromium.googlesource.com/chromium/src/+/e038518f79d429d7ccebaa16aae92773bf238459

[chrishtr, 2017-03-23 17:12:32]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-23 17:13:58]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't squash any PaintLayer into another PaintLayer that has scrolling.

Previously, we had done this correctly for overflow scrolling, but not for
induced
scrolling due to input boxes or overflow:auto.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[amineer, 2017-03-23 17:30:12]

amineer@chromium.org changed reviewers:
+ amineer@chromium.org

[amineer, 2017-03-23 17:30:13]

https://codereview.chromium.org/2770943003/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
(right):

https://codereview.chromium.org/2770943003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp:136:
// permit the video to share a backing with other laycers.
typo?

[chrishtr, 2017-03-23 18:33:06]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org
- amineer@chromium.org

[pdr., 2017-03-23 18:35:19]

On 2017/03/23 at 18:33:06, chrishtr wrote:
> 

LGTM but I think we will need to understand the pos:rel/overflow:hidden to merge
to stable.

[chrishtr, 2017-03-23 18:36:12]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:36:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:10:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-03-23 20:20:31]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-23 20:20:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps60001
(title: "none")

[commit-bot: I haz the power, 2017-03-23 20:21:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-23 21:53:36]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-23 22:22:39]

Description was changed from

==========
Don't squash any PaintLayer into another PaintLayer that has scrolling.

Previously, we had done this correctly for overflow scrolling, but not for
induced
scrolling due to input boxes or overflow:auto.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Include control clip in list of clip-related properties.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-03-23 22:22:52]

PTAL, now with new implementation.

[chrishtr, 2017-03-23 22:23:12]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 22:24:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-03-23 22:27:00]

LGTM

https://codereview.chromium.org/2770943003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2770943003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:427: bool
LayoutObject::hasClipRelatedProperty() const {
Please remove the hasControlClip call in
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize

[chrishtr, 2017-03-23 22:32:05]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2017-03-23 22:32:10]

https://codereview.chromium.org/2770943003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2770943003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:427: bool
LayoutObject::hasClipRelatedProperty() const {
On 2017/03/23 at 22:27:00, pdr. wrote:
> Please remove the hasControlClip call in
LayoutBox::paintedOutputOfObjectHasNoEffectRegardlessOfSize

Done.

[chrishtr, 2017-03-23 22:32:14]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-23 22:32:15]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-23 22:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps160001
(title: "none")

[commit-bot: I haz the power, 2017-03-23 22:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-03-23 22:38:18]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-23 22:44:16]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-23 22:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps180001
(title: "none")

[commit-bot: I haz the power, 2017-03-23 22:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:15:22]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-03-23 23:16:28]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:37:07]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[chrishtr, 2017-03-23 23:50:30]

Updated to fix a DCHECK in CompositingInputsUpdater to exclude control clip.

[chrishtr, 2017-03-23 23:51:39]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-23 23:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps220001
(title: "none")

[commit-bot: I haz the power, 2017-03-23 23:52:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 01:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 01:23:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-03-24 03:35:44]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-24 03:35:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps240001
(title: "none")

[commit-bot: I haz the power, 2017-03-24 03:36:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 04:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:53:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2017-03-24 04:56:03]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:56:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 06:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:10:15]

Failed to apply patch for
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:48
  error:
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
Index:
third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
diff --git
a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
index
53d5dfb1acd5d8d7b2625c133039496d26ee4999..1418b28686d0d4621e09c71cc5fdef1d18ca750f
100644
---
a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
+++
b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
@@ -48,10 +48,12 @@ static const PaintLayer*
findParentLayerOnClippingContainerChain(
     if (current->hasLayer())
       return static_cast<const LayoutBoxModelObject*>(current)->layer();
     // Having clip or overflow clip forces the LayoutObject to become a layer,
-    // except for contains: paint, which may apply to SVG.
+    // except for contains: paint, which may apply to SVG, and
+    // control clip, which may apply to LayoutBox subtypes.
     // SVG (other than LayoutSVGRoot) cannot have PaintLayers.
     DCHECK(!current->hasClipRelatedProperty() ||
-           current->styleRef().containsPaint());
+           current->styleRef().containsPaint() ||
+           (current->isBox() && toLayoutBox(current)->hasControlClip()));
   }
   ASSERT_NOT_REACHED();
   return nullptr;

[chrishtr, 2017-03-24 12:13:12]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-03-24 12:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943003/#ps260001
(title: "Merge branch 'master' into squash")

[chrishtr, 2017-03-24 12:13:17]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2017-03-24 12:13:26]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-03-24 12:13:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 13:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1490357606411430,
"parent_rev": "a3f8fd183b59f68afba5b99668cae20e7d26e330", "commit_rev":
"e038518f79d429d7ccebaa16aae92773bf238459"}

[commit-bot: I haz the power, 2017-03-24 13:38:12]

Description was changed from

==========
Include control clip in list of clip-related properties.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Include control clip in list of clip-related properties.

BUG=704292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2770943003
Cr-Commit-Position: refs/heads/master@{#459407}
Committed:
https://chromium.googlesource.com/chromium/src/+/e038518f79d429d7ccebaa16aae9...
==========

[commit-bot: I haz the power, 2017-03-24 13:38:14]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/e038518f79d429d7ccebaa16aae9...