Remove ExtractImageRep from the browser frame header painting code.

Remove ExtractImageRep from the browser frame header painting code.

PaintFrameImagesInRoundRect() would use an intermediate bitmap to
images into, then draw that bitmap with a clip and blendmode back
into the original canvas. We can do this instead with SaveLayer.

This adds a SaveLayer variant that takes an arbitrary PaintFlags, to
allow this use case, and uses that instead of generating an extra
bitmap on the CPU.

While here, we improve the readability of this code some by removing
an always-false if condition (isSrcOver) and moving code closer so
that we prove it is always false and stays that way.

R=bsep@chromium.org, pkasting@chromium.org
BUG=671433
Review-Url: https://codereview.chromium.org/2770943002
Cr-Commit-Position: refs/heads/master@{#458929}
Committed: https://chromium.googlesource.com/chromium/src/+/226e88f271fb6fc8a47110d440c9e12662edec95

[danakj, 2017-03-22 22:11:43]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:12:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-22 22:14:01]

Because I don't think there's any pixel tests here's a series of images of what
this looks like before and after. This is using a clip of a path instead of
"draw path" commands, which avoids the use of an SkShader (a concept we're going
to work on removing/changing in the future).

I think this is exactly the same output. The last case I had to take pictures
mid-cross-fade animation so they aren't as obviously the same pixel values, but
the spirit is the same :)

Each image is before-then-after this patch: http://imgur.com/a/tXsDi

[danakj, 2017-03-22 22:16:12]

On 2017/03/22 22:14:01, danakj wrote:
> Because I don't think there's any pixel tests here's a series of images of
what
> this looks like before and after. This is using a clip of a path instead of
> "draw path" commands, which avoids the use of an SkShader (a concept we're
going
> to work on removing/changing in the future).
> 
> I think this is exactly the same output. The last case I had to take pictures
> mid-cross-fade animation so they aren't as obviously the same pixel values,
but
> the spirit is the same :)
> 
> Each image is before-then-after this patch: http://imgur.com/a/tXsDi

TBH the greys look a bit diff before and after in the first 2 there. But in my
local pngs they are both exactly #ccc.

[Peter Kasting, 2017-03-22 22:25:57]

LGTM!

https://codereview.chromium.org/2770943002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_header_painter_ash.cc (right):

https://codereview.chromium.org/2770943002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_header_painter_ash.cc:71: canvas->Save();
Nit: Prefer ScopedCanvas to explicit Save()/Restore() pairing

[danakj, 2017-03-22 22:27:38]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-03-22 22:27:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943002/#ps20001
(title: "header-bitmap: scopedcanvas")

[danakj, 2017-03-22 22:27:47]

https://codereview.chromium.org/2770943002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_header_painter_ash.cc (right):

https://codereview.chromium.org/2770943002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_header_painter_ash.cc:71: canvas->Save();
On 2017/03/22 22:25:57, Peter Kasting wrote:
> Nit: Prefer ScopedCanvas to explicit Save()/Restore() pairing

Oh thanks, I was looking for that.. but I thot it had another name. Done.

[commit-bot: I haz the power, 2017-03-22 22:28:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-22 22:28:52]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-03-22 22:28:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943002/#ps40001
(title: "header-bitmap: headers")

[commit-bot: I haz the power, 2017-03-22 22:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-03-22 22:29:12]

The CQ bit was checked by danakj@chromium.org

[danakj, 2017-03-22 22:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2770943002/#ps60001
(title: "header-bitmap: headers")

[danakj, 2017-03-22 22:29:18]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-03-22 22:29:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2017-03-22 22:32:13]

lgtm as well

[commit-bot: I haz the power, 2017-03-22 23:27:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490221752297600,
"parent_rev": "63dd720c98271a15da8e483906dc92c3d0603e7d", "commit_rev":
"226e88f271fb6fc8a47110d440c9e12662edec95"}

[commit-bot: I haz the power, 2017-03-22 23:28:33]

Description was changed from

==========
Remove ExtractImageRep from the browser frame header painting code.

PaintFrameImagesInRoundRect() would use an intermediate bitmap to
images into, then draw that bitmap with a clip and blendmode back
into the original canvas. We can do this instead with SaveLayer.

This adds a SaveLayer variant that takes an arbitrary PaintFlags, to
allow this use case, and uses that instead of generating an extra
bitmap on the CPU.

While here, we improve the readability of this code some by removing
an always-false if condition (isSrcOver) and moving code closer so
that we prove it is always false and stays that way.

R=bsep@chromium.org, pkasting@chromium.org
BUG=671433
==========

to

==========
Remove ExtractImageRep from the browser frame header painting code.

PaintFrameImagesInRoundRect() would use an intermediate bitmap to
images into, then draw that bitmap with a clip and blendmode back
into the original canvas. We can do this instead with SaveLayer.

This adds a SaveLayer variant that takes an arbitrary PaintFlags, to
allow this use case, and uses that instead of generating an extra
bitmap on the CPU.

While here, we improve the readability of this code some by removing
an always-false if condition (isSrcOver) and moving code closer so
that we prove it is always false and stays that way.

R=bsep@chromium.org, pkasting@chromium.org
BUG=671433

Review-Url: https://codereview.chromium.org/2770943002
Cr-Commit-Position: refs/heads/master@{#458929}
Committed:
https://chromium.googlesource.com/chromium/src/+/226e88f271fb6fc8a47110d440c9...
==========

[commit-bot: I haz the power, 2017-03-22 23:28:34]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/226e88f271fb6fc8a47110d440c9...