Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2770933007: [Sync] Replace ClearServerDataCallback with Closure. (Closed)

Created:
3 years, 9 months ago by skym
Modified:
3 years, 9 months ago
Reviewers:
Patrick Noland, pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Replace ClearServerDataCallback with Closure. ClearServerDataCallback was previously typedef'ed to be the same thing as base::Closure. I don't see any value in maintaining a useless typedef until we actually need it. BUG= Review-Url: https://codereview.chromium.org/2770933007 Cr-Commit-Position: refs/heads/master@{#459493} Committed: https://chromium.googlesource.com/chromium/src/+/a4956016be9efde7ea80dafcd35207e91e23f56f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -34 lines) Patch
M components/browser_sync/profile_sync_service_unittest.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/engine/fake_sync_engine.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/fake_sync_engine.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/fake_sync_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine/fake_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/sync_engine.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/sync/engine/sync_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (14 generated)
skym
PTAL
3 years, 9 months ago (2017-03-24 15:55:30 UTC) #6
Patrick Noland
lgtm
3 years, 9 months ago (2017-03-24 18:08:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770933007/1
3 years, 9 months ago (2017-03-24 18:13:19 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-24 18:13:21 UTC) #14
skym
+pavely for a committers review.
3 years, 9 months ago (2017-03-24 18:21:37 UTC) #16
pavely
lgtm
3 years, 9 months ago (2017-03-24 18:27:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770933007/1
3 years, 9 months ago (2017-03-24 18:36:15 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:48:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4956016be9efde7ea80dafcd352...

Powered by Google App Engine
This is Rietveld 408576698