Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2770933002:
[ash-md] Cleans up non-MD code path from VPN detailed page (Closed)
|
Created:
3 years, 9 months ago by varkha Modified:
3 years, 9 months ago Reviewers:
tdanderson CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ash-md] Cleans up non-MD code path from VPN detailed page
Code deletion, there should be no functional change.
BUG=686258
Review-Url: https://codereview.chromium.org/2770933002
Cr-Commit-Position: refs/heads/master@{#459293}
Committed: https://chromium.googlesource.com/chromium/src/+/5e488721e5f9119b9cd772ca02891188a6d83383
Patch Set 1 #
Total comments: 4
Patch Set 2 : [ash-md] Cleans up non-MD code path from VPN detailed page (nit) #Patch Set 3 : [ash-md] Cleans up non-MD code path from VPN detailed page (rebase) #Patch Set 4 : [ash-md] Cleans up non-MD code path from VPN detailed page (rebase) #Messages
Total messages: 25 (20 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
varkha@chromium.org changed reviewers: + tdanderson@chromium.org
tdanderson@, can you please take a look? Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/network/vpn_list_view.cc:2: // Use of this source code is governed by a BSD-style license that can be note: I suggest that your other CL https://chromiumcodereview.appspot.com/2768973002/ be landed first and merged back to m-58 before this cleanup CL goes into ToT. https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/network/vpn_list_view.cc:49: #include "ui/views/layout/box_layout.h" nit: I think you can delete this now
https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/network/vpn_list_view.cc:2: // Use of this source code is governed by a BSD-style license that can be On 2017/03/22 23:39:55, tdanderson wrote: > note: I suggest that your other CL > https://chromiumcodereview.appspot.com/2768973002/ be landed first and merged > back to m-58 before this cleanup CL goes into ToT. Makes sense. Will wait. https://codereview.chromium.org/2770933002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/network/vpn_list_view.cc:49: #include "ui/views/layout/box_layout.h" On 2017/03/22 23:39:55, tdanderson wrote: > nit: I think you can delete this now Done.
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by varkha@chromium.org
The CQ bit was checked by varkha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2770933002/#ps60001 (title: "[ash-md] Cleans up non-MD code path from VPN detailed page (rebase)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490312789266570,
"parent_rev": "4caad9b23170f974e819e287e647256101959197", "commit_rev":
"5e488721e5f9119b9cd772ca02891188a6d83383"}
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Cleans up non-MD code path from VPN detailed page Code deletion, there should be no functional change. BUG=686258 ========== to ========== [ash-md] Cleans up non-MD code path from VPN detailed page Code deletion, there should be no functional change. BUG=686258 Review-Url: https://codereview.chromium.org/2770933002 Cr-Commit-Position: refs/heads/master@{#459293} Committed: https://chromium.googlesource.com/chromium/src/+/5e488721e5f9119b9cd772ca0289... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5e488721e5f9119b9cd772ca0289... |
