Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2770913004: Disabling startup.large_profile.warm.blank_page on Windows (Closed)

Created:
3 years, 9 months ago by ashleymarie1
Modified:
3 years, 9 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling startup.large_profile.warm.blank_page on Windows BUG=chromium:704137 Review-Url: https://codereview.chromium.org/2770913004 Cr-Commit-Position: refs/heads/master@{#459113} Committed: https://chromium.googlesource.com/chromium/src/+/2afcd73c4d28db6974d3166cfe9427106f46d051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/startup.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ashleymarie1
This benchmark doesn't seem to have a current owner so I'm not sure who to ...
3 years, 9 months ago (2017-03-23 15:28:28 UTC) #2
nednguyen
lgtm
3 years, 9 months ago (2017-03-23 15:30:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770913004/1
3 years, 9 months ago (2017-03-23 15:32:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2afcd73c4d28db6974d3166cfe9427106f46d051
3 years, 9 months ago (2017-03-23 16:36:35 UTC) #8
erikchen
On 2017/03/23 16:36:35, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-23 17:17:18 UTC) #9
ashleymarie1
3 years, 9 months ago (2017-03-23 17:21:29 UTC) #10
Message was sent while issue was closed.
On 2017/03/23 17:17:18, erikchen wrote:
> On 2017/03/23 16:36:35, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/2afcd73c4d28db6974d3166cfe94...
> 
> ashleymarie: could you respond to my comment at
> https://bugs.chromium.org/p/chromium/issues/detail?id=704137#c12? 
> 
> It's possible that the benchmark is outdated and the profile needs to be
> updated, it's also possible that there's a real performance regression caused
by
> gangwu's change.

I'm don't know if we're looking at a real regression or an outdated benchmark
here. I just figured we should disable it for now since there is a bug tracking
it. Ned, any chance you have insight into what's going on here?

Powered by Google App Engine
This is Rietveld 408576698