Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2770903002: [Chromecast] Remove redundant build assert. (Closed)

Created:
3 years, 9 months ago by Joshua LeVasseur
Modified:
3 years, 9 months ago
Reviewers:
wzhong, slan, lcwu, halliwell, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Remove redundant build assert. Bug: internal b/36147674 Test: none Change-Id: Ie1cf508c019c06fc07424a0fc31f8719f425a768 Review-Url: https://codereview.chromium.org/2770903002 Cr-Commit-Position: refs/heads/master@{#459242} Committed: https://chromium.googlesource.com/chromium/src/+/c9c897ae121e199cc1902ab9d449e73971846fff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chromecast/chromecast.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Joshua LeVasseur
3 years, 9 months ago (2017-03-22 21:40:15 UTC) #2
wzhong
lgtm
3 years, 9 months ago (2017-03-22 21:56:16 UTC) #3
Joshua LeVasseur
3 years, 9 months ago (2017-03-23 16:58:21 UTC) #5
Joshua LeVasseur
This helps run assistant on x86 and video
3 years, 9 months ago (2017-03-23 19:57:57 UTC) #7
slan
lgtm! Except one nit on the commit message: I don't think "redundant" is the right ...
3 years, 9 months ago (2017-03-23 20:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770903002/1
3 years, 9 months ago (2017-03-23 20:25:37 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 22:00:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c9c897ae121e199cc1902ab9d449...

Powered by Google App Engine
This is Rietveld 408576698