Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 27708002: GYP variable v8_optimized_debug should be overridable by GYP_DEFINES (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Michael Starzinger
Visibility:
Public.

Description

GYP variable v8_optimized_debug should be overridable by GYP_DEFINES This re-lands r226772. The issue that caused the revert has been fixed on the V8 side. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/common.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
Let's try this again. The issue we hit last time was fixed in V8 3.22.12 ...
7 years, 2 months ago (2013-10-17 13:58:12 UTC) #1
Dirk Pranke
lgtm
7 years, 2 months ago (2013-10-17 17:52:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/27708002/1
7 years, 2 months ago (2013-10-18 08:09:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/27708002/1
7 years, 2 months ago (2013-10-18 21:49:55 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-19 22:44:24 UTC) #5
Message was sent while issue was closed.
Change committed as 229634

Powered by Google App Engine
This is Rietveld 408576698