GYP variable v8_optimized_debug should be overridable by GYP_DEFINES

GYP variable v8_optimized_debug should be overridable by GYP_DEFINES

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226772

[Jakob Kummerow, 2013-10-01 15:32:10]

Please take a look.

[Dirk Pranke, 2013-10-02 18:08:02]

Looks plausible to me. For some reason I seem to recall that I had tried this
and it didn't work, but it seems like it should, so if this works for you, lgtm.

[commit-bot: I haz the power, 2013-10-03 12:18:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jkummerow@chromium.org/25430003/1

[commit-bot: I haz the power, 2013-10-03 12:18:11]

Failed to apply patch for build/common.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/common.gypi
  Hunk #1 succeeded at 736 (offset 1 line).
  Hunk #2 FAILED at 895.
  1 out of 2 hunks FAILED -- saving rejects to file build/common.gypi.rej

Patch:       build/common.gypi
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index
702135fd54dda83b2fedbea8d113dade39a0a8de..52ef7eb9d5fcf936923d1589922dfc0f61f4c9a2
100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -735,9 +735,9 @@
         # on android_clang, where we're hitting a weird linker error.
         # TODO(dpranke): http://crbug.com/266155 .
         ['OS=="android"', {
-          'v8_optimized_debug': 1,
+          'v8_optimized_debug%': 1,
         }, {
-          'v8_optimized_debug': 2,
+          'v8_optimized_debug%': 2,
         }],
       ],
 
@@ -895,7 +895,7 @@
     'spdy_proxy_auth_property%': '<(spdy_proxy_auth_property)',
     'spdy_proxy_auth_value%': '<(spdy_proxy_auth_value)',
     'enable_mdns%' : '<(enable_mdns)',
-    'v8_optimized_debug': '<(v8_optimized_debug)',
+    'v8_optimized_debug%': '<(v8_optimized_debug)',
     'proprietary_codecs%': '<(proprietary_codecs)',
 
     # Use system nspr instead of the bundled one.

[commit-bot: I haz the power, 2013-10-03 12:20:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jkummerow@chromium.org/25430003/7001

[commit-bot: I haz the power, 2013-10-03 14:08:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-10-03 16:27:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jkummerow@chromium.org/25430003/7001

[commit-bot: I haz the power, 2013-10-03 16:36:02]

Change committed as 226772

[Dirk Pranke, 2013-10-03 21:00:42]

It looks like this didn't work in the default (no GYP_DEFINES) case. I've
reverted this in r226843 ( https://codereview.chromium.org/25932002 ).

You can see the regression in
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htm...
.