Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2770783002:
Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. (Closed)
Description[reland] Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc.
This CL was reverted because of flakiness on try jobs that
ran on early patch sets. Errors were fixed on the patch set
that landed.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=stevenjb@chromium.org
Review-Url: https://codereview.chromium.org/2770783002
Cr-Original-Commit-Position: refs/heads/master@{#466677}
Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de407e48d89476
Review-Url: https://codereview.chromium.org/2770783002
Cr-Commit-Position: refs/heads/master@{#468365}
Committed: https://chromium.googlesource.com/chromium/src/+/da7a05ce675223919327ef0c24226bbe16842c7b
Patch Set 1 #Patch Set 2 : ScopedAsyncTaskScheduler #Patch Set 3 : ScopedAsyncTaskScheduler #Patch Set 4 : flush-task-scheduler #Patch Set 5 : self-review #Patch Set 6 : add-include #
Messages
Total messages: 49 (36 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL On 2017/03/22 19:30:19, fdoray wrote: > PTAL! > > This CL was generated automatically. > > Please make sure that the appropriate TaskTraits are used to post tasks. > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > If everything looks good, please lgtm and CQ this CL. Otherwise, tell > us what's wrong. > > Thanks! > > - FAQ - > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > What if the task priority is not set explicitly (no .WithTaskPriority)? > When there is no explicit priority, the priority is inherited from the > calling context (e.g. a task posted from a BACKGROUND task without an > explicit priority will have a BACKGROUND priority). > > What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior)? > If shutdown behavior is important for a task, it should be set explicitly. > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN > or SKIP_ON_SHUTDOWN.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493055652160750, "parent_rev":
"4c16aaa21c6f8a4cc6b392a9474fda426f9f36a1", "commit_rev":
"b67baf11ed95e0e7eb570d99b6de407e48d89476"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2842563002/ by hcarmona@chromium.org. The reason for reverting is: Reverting b/c of chromeos test failures: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....
Message was sent while issue was closed.
Findit(https://goo.gl/kROfz5) identified this CL at revision 466677 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ========== to ========== Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ==========
Added ScopedAsyncTaskScheduler to fix test failure. Relanding.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2770783002/#ps40001 (title: "ScopedAsyncTaskScheduler")
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2770783002/#ps60001 (title: "flush-task-scheduler")
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fdoray@chromium.org
Description was changed from ========== Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. This CL was reverted because of flakiness on try jobs that ran on early patch sets. Errors were fixed on the patch set that landed. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ==========
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2770783002/#ps100001 (title: "add-include")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493660410002750,
"parent_rev": "2644729cb7722a702a76cc2758d0ce372e1e6f92", "commit_rev":
"da7a05ce675223919327ef0c24226bbe16842c7b"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. This CL was reverted because of flakiness on try jobs that ran on early patch sets. Errors were fixed on the patch set that landed. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... ========== to ========== [reland] Use TaskScheduler instead of blocking pool in automatic_reboot_manager.cc. This CL was reverted because of flakiness on try jobs that ran on early patch sets. Errors were fixed on the patch set that landed. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2770783002 Cr-Original-Commit-Position: refs/heads/master@{#466677} Committed: https://chromium.googlesource.com/chromium/src/+/b67baf11ed95e0e7eb570d99b6de... Review-Url: https://codereview.chromium.org/2770783002 Cr-Commit-Position: refs/heads/master@{#468365} Committed: https://chromium.googlesource.com/chromium/src/+/da7a05ce675223919327ef0c2422... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/da7a05ce675223919327ef0c2422... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
