chrome/browser/extensions/test_extension_dir.cc - Issue 2770753006: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/test_extension_dir.cc

Issue 2770753006: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS. (Closed)

Patch Set: hoist! Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/test_extension_dir.cc

diff --git a/chrome/browser/extensions/test_extension_dir.cc b/chrome/browser/extensions/test_extension_dir.cc

index dc7e2926e2fc562492515ef0ef6b902e7097730b..79cfdf981ef5e7a2949224c167e0dc633d2dec42 100644

--- a/chrome/browser/extensions/test_extension_dir.cc

+++ b/chrome/browser/extensions/test_extension_dir.cc

@@ -67,7 +67,7 @@ base::FilePath TestExtensionDir::Pack() {

}

base::FilePath TestExtensionDir::UnpackedPath() {

- return dir_.GetPath();

+ return base::MakeAbsoluteFilePath(dir_.GetPath());

Devlin 2017/04/03 17:25:22 Can we add a comment explaining why this is import

}

} // namespace extensions

« no previous file with comments | « base/files/file_util_mac.mm ('k') | no next file » | no next file with comments »