chrome/browser/extensions/test_extension_dir.cc - Issue 2770753006: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/test_extension_dir.cc

Issue 2770753006: [base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS. (Closed)

Patch Set: hoist! Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/files/file_util_mac.mm ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/test_extension_dir.h"	5 #include "chrome/browser/extensions/test_extension_dir.h"

6	6

7 #include "base/files/file_util.h"	7 #include "base/files/file_util.h"

8 #include "base/json/json_writer.h"	8 #include "base/json/json_writer.h"

9 #include "base/numerics/safe_conversions.h"	9 #include "base/numerics/safe_conversions.h"

10 #include "base/strings/string_util.h"	10 #include "base/strings/string_util.h"

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 return base::FilePath();	60 return base::FilePath();

61 }	61 }

62 if (!base::PathExists(crx_path)) {	62 if (!base::PathExists(crx_path)) {

63 ADD_FAILURE() << crx_path.value() << " was not created.";	63 ADD_FAILURE() << crx_path.value() << " was not created.";

64 return base::FilePath();	64 return base::FilePath();

65 }	65 }

66 return crx_path;	66 return crx_path;

67 }	67 }

68	68

69 base::FilePath TestExtensionDir::UnpackedPath() {	69 base::FilePath TestExtensionDir::UnpackedPath() {

70 return dir_.GetPath();	70 return base::MakeAbsoluteFilePath(dir_.GetPath());
	Devlin 2017/04/03 17:25:22 Can we add a comment explaining why this is import Can we add a comment explaining why this is important?
71 }	71 }

72	72

73 } // namespace extensions	73 } // namespace extensions

OLD	NEW