Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2770733003: Reland [iOS] Disable NSAssert and GTMDevAssert on release builds. (Closed)

Created:
3 years, 9 months ago by baxley
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland [iOS] Disable NSAssert and GTMDevAssert on release builds. This was present in build/common.gypi and was inadvertently dropped during the conversion to GN (removed by http://crrev.com/2355673003, but hadn't been added to GN). patch from issue 2637853002 at patchset 20001 (http://crrev.com/2637853002#ps20001) BUG=673253 Review-Url: https://codereview.chromium.org/2770733003 Cr-Commit-Position: refs/heads/master@{#461841} Committed: https://chromium.googlesource.com/chromium/src/+/45196266f164836fca6d41e8f9cfad0eee0b91a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/config/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
baxley
The EG roll has landed, so we can reland this.
3 years, 9 months ago (2017-03-23 14:18:23 UTC) #2
sdefresne
lgtm
3 years, 9 months ago (2017-03-23 15:57:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770733003/1
3 years, 9 months ago (2017-03-23 15:58:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/392914)
3 years, 9 months ago (2017-03-23 16:07:48 UTC) #7
baxley
+dpranke@ for OWNERS
3 years, 9 months ago (2017-03-23 16:31:28 UTC) #9
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-04 02:19:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770733003/1
3 years, 8 months ago (2017-04-04 21:07:34 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 21:16:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45196266f164836fca6d41e8f9cf...

Powered by Google App Engine
This is Rietveld 408576698