Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2770723004: Remove all ReadingList entries on managed account signout. (Closed)

Created:
3 years, 9 months ago by Olivier
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Remove all ReadingList entries on managed account signout. Clearing happens after the actual signout, so only local data is deleted. Also interrupt current distillation on signout as profile may change. BUG=699590 Review-Url: https://codereview.chromium.org/2745313004 Cr-Commit-Position: refs/heads/master@{#458377} (cherry picked from commit 85c6bf63ddea1f0a18f2404090acb96f67369ca2) Review-Url: https://codereview.chromium.org/2770723004 . Cr-Commit-Position: refs/branch-heads/3029@{#380} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8e3637fbb0c5adf4a37f36c059a85dccae1b1f40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -2 lines) Patch
M components/reading_list/ios/favicon_web_state_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/reading_list/ios/reading_list_model_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl.mm View 1 chunk +6 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page_factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_distiller_page_factory.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_download_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A ios/chrome/browser/reading_list/reading_list_remover_helper.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/chrome/browser/reading_list/reading_list_remover_helper.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/reading_list/url_downloader.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/signin/browser_state_data_remover.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/browser_state_data_remover.mm View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 9 months ago (2017-03-23 09:07:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e3637fbb0c5adf4a37f36c059a85dccae1b1f40.

Powered by Google App Engine
This is Rietveld 408576698