Fix MaximizeModeController startup race

Fix MaximizeModeController startup race

MaximizeModeController receives signals from PowerManagerClient regarding state
changes of the lid and tablet switch. These are sent from powerd.

However it is possible for these state changes to occur before Chrome is
running. Leading to MaximizeModeController never being told of their state.

This change utilizes the new ability to poll the initial state.

TEST=MaximizeModeControllerTest.InitializedWhileTabletModeSwitchOn
BUG=36452425
Review-Url: https://codereview.chromium.org/2770723002
Cr-Commit-Position: refs/heads/master@{#459155}
Committed: https://chromium.googlesource.com/chromium/src/+/0e190474ec6f3ddd09c3781fe5d57da50900df90

[jonross, 2017-03-23 00:39:24]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:40:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 01:08:19]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[jonross, 2017-03-23 02:04:51]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 02:05:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 02:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:46:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2017-03-23 14:54:54]

jonross@chromium.org changed reviewers:
+ flackr@chromium.org

[jonross, 2017-03-23 14:54:55]

Hey Rob, could you take a look at this review?

It's an update to poll the tablet_mode_switch at startup.

[flackr, 2017-03-23 16:47:49]

LGTM

[jonross, 2017-03-23 16:51:26]

jonross@chromium.org changed reviewers:
+ oshima@chromium.org

[jonross, 2017-03-23 16:51:26]

oshima@chromium.org: Please review changes in 

ash/common/wm/maximize_mode/maximize_mode_controller.*

This updates uses a new polling method to determine the state of the tablet mode
switch at startup. As it can be set before chrome is started.

Thanks,
Jon

[oshima, 2017-03-23 17:43:52]

lgtm

[jonross, 2017-03-23 17:48:03]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:48:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:36:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490291283712750,
"parent_rev": "19f68dd015feecd2edd94a1a90e21fdcf3a1147f", "commit_rev":
"0e190474ec6f3ddd09c3781fe5d57da50900df90"}

[commit-bot: I haz the power, 2017-03-23 18:37:05]

Description was changed from

==========
Fix MaximizeModeController startup race

MaximizeModeController receives signals from PowerManagerClient regarding state
changes of the lid and tablet switch. These are sent from powerd.

However it is possible for these state changes to occur before Chrome is
running. Leading to MaximizeModeController never being told of their state.

This change utilizes the new ability to poll the initial state.

TEST=MaximizeModeControllerTest.InitializedWhileTabletModeSwitchOn
BUG=36452425
==========

to

==========
Fix MaximizeModeController startup race

MaximizeModeController receives signals from PowerManagerClient regarding state
changes of the lid and tablet switch. These are sent from powerd.

However it is possible for these state changes to occur before Chrome is
running. Leading to MaximizeModeController never being told of their state.

This change utilizes the new ability to poll the initial state.

TEST=MaximizeModeControllerTest.InitializedWhileTabletModeSwitchOn
BUG=36452425

Review-Url: https://codereview.chromium.org/2770723002
Cr-Commit-Position: refs/heads/master@{#459155}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e190474ec6f3ddd09c3781fe5d5...
==========

[commit-bot: I haz the power, 2017-03-23 18:37:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0e190474ec6f3ddd09c3781fe5d5...