Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2770713004: Fix position of layer with floating ancestor within inline parent layer (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix position of layer with floating ancestor within inline parent layer <span style="position: relative"> ... <div style="float: left"> ... <target layer> ... </div> ... </span> Because of the floating ancestor, the containing layer of target layer is not the span, but the layer found in the containing block chain. BUG=703666, 703481 NOTRY=true NOPRESUBMIT=true TBR=wangxianzhu@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2761413002 Cr-Original-Commit-Position: refs/heads/master@{#458857} Review-Url: https://codereview.chromium.org/2770713004 Cr-Commit-Position: refs/branch-heads/3029@{#375} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/a63a4e804574974a127ee0920f65628374257ebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 2 chunks +26 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770713004/1
3 years, 9 months ago (2017-03-22 23:52:53 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 23:57:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a63a4e804574974a127ee0920f65...

Powered by Google App Engine
This is Rietveld 408576698