Enable page selection for WebView printing

android_webview/native/aw_pdf_exporter.h

Index: android_webview/native/aw_pdf_exporter.h
diff --git a/android_webview/native/aw_pdf_exporter.h b/android_webview/native/aw_pdf_exporter.h
index aa08b5f67d6aa7ac62cd3bf88134a97fe15b74fd..6145e86e4786de6125844dd2544e3e1100917fbc 100644
--- a/android_webview/native/aw_pdf_exporter.h
+++ b/android_webview/native/aw_pdf_exporter.h
@@ -11,6 +11,8 @@
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 
+#include "printing/page_range.h"
+
 namespace content {
 class WebContents;
 };
@@ -32,11 +34,13 @@ class AwPdfExporter {
   void ExportToPdf(JNIEnv* env,
                    const base::android::JavaParamRef<jobject>& obj,
                    int fd,
+                   jintArray pages,
                    const base::android::JavaParamRef<jobject>& cancel_signal);
 
  private:
   void InitPdfSettings(JNIEnv* env,
                        const base::android::JavaRef<jobject>& obj,
+                       const printing::PageRanges& page_ranges,

[Lei Zhang, 2017/03/22 22:26:43]

You can forward declare instead.

[Shimi Zhang, 2017/03/23 17:59:07]

thestig@, this is a typedef, which I think we can't forward declare, the
declaration is:

typedef std::vector<PageRange> PageRanges; 

in printing/page_range.h. Correct me if I am wrong.

With this assumption if we want to remove #include "printing/page_range.h" here,
I came up with one solution:

Since I converted jintArray to vector<int> and then convert vector<int> to
PageRanges outside InitPdfSettings function, we could move the second part into
InitPdfSettings and replace this param with a vector<int>, we could also remove
GetPageRanges function in aw_pdf_exporter.cc.

How do you think?

[Lei Zhang, 2017/03/23 19:35:18]

OK, I didn't check. Ignore my comment then. No need to over-think it.

[Shimi Zhang, 2017/03/23 23:21:56]

Done.

                        printing::PrintSettings& settings);
   void DidExportPdf(int fd, bool success);