Enable page selection for WebView printing

android_webview/native/aw_pdf_exporter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_NATIVE_AW_PDF_EXPORTER_H_
 #define ANDROID_WEBVIEW_NATIVE_AW_PDF_EXPORTER_H_
 
 #include <jni.h>
 
 #include "base/android/jni_weak_ref.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/macros.h"
 
+#include "printing/page_range.h"
+
 namespace content {
 class WebContents;
 };
 
 namespace printing {
 class PrintSettings;
 };
 
 namespace android_webview {
 
 class AwPdfExporter {
  public:
   AwPdfExporter(JNIEnv* env,
                 const base::android::JavaRef<jobject>& obj,
                 content::WebContents* web_contents);
 
   ~AwPdfExporter();
 
   void ExportToPdf(JNIEnv* env,
                    const base::android::JavaParamRef<jobject>& obj,
                    int fd,
+                   jintArray pages,
                    const base::android::JavaParamRef<jobject>& cancel_signal);
 
  private:
   void InitPdfSettings(JNIEnv* env,
                        const base::android::JavaRef<jobject>& obj,
+                       const printing::PageRanges& page_ranges,

[Lei Zhang, 2017/03/22 22:26:43]

You can forward declare instead.

[Shimi Zhang, 2017/03/23 17:59:07]

thestig@, this is a typedef, which I think we can't forward declare, the
declaration is:

typedef std::vector<PageRange> PageRanges; 

in printing/page_range.h. Correct me if I am wrong.

With this assumption if we want to remove #include "printing/page_range.h" here,
I came up with one solution:

Since I converted jintArray to vector<int> and then convert vector<int> to
PageRanges outside InitPdfSettings function, we could move the second part into
InitPdfSettings and replace this param with a vector<int>, we could also remove
GetPageRanges function in aw_pdf_exporter.cc.

How do you think?

[Lei Zhang, 2017/03/23 19:35:18]

OK, I didn't check. Ignore my comment then. No need to over-think it.

[Shimi Zhang, 2017/03/23 23:21:56]

Done.

                        printing::PrintSettings& settings);
   void DidExportPdf(int fd, bool success);
 
   JavaObjectWeakGlobalRef java_ref_;
   content::WebContents* web_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(AwPdfExporter);
 };
 
 bool RegisterAwPdfExporter(JNIEnv* env);
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_NATIVE_AW_PDF_EXPORTER_H_