Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2770713002: Add a DevTools warning for a missing subjectAltName (Closed)

Created:
3 years, 9 months ago by Ryan Sleevi
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add a DevTools warning for a missing subjectAltName BUG=703616 Review-Url: https://codereview.chromium.org/2761333002 Cr-Commit-Position: refs/heads/master@{#458631} (cherry picked from commit 74a7a294c2802cf5b65bf0c0d4f44ba093aae216) Review-Url: https://codereview.chromium.org/2770713002 . Cr-Commit-Position: refs/branch-heads/3029@{#363} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/9fc258ccd72adb084aacbabe86a9c1829cc8217f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -106 lines) Patch
M components/security_state/content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/security_state/content/content_utils.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/security_state/content/content_utils_unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M components/security_state/core/security_state.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/security_state/core/security_state.cc View 2 chunks +7 lines, -1 line 0 comments Download
M components/security_state/core/security_state_unittest.cc View 3 chunks +24 lines, -1 line 0 comments Download
M components/security_state_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M net/cert/x509_certificate.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_ios.cc View 3 chunks +32 lines, -28 lines 0 comments Download
M net/cert/x509_certificate_mac.cc View 2 chunks +25 lines, -12 lines 0 comments Download
M net/cert/x509_certificate_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_openssl.cc View 3 chunks +30 lines, -27 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 2 chunks +18 lines, -1 line 0 comments Download
M net/cert/x509_certificate_win.cc View 2 chunks +23 lines, -12 lines 0 comments Download
M net/cert/x509_util_nss.h View 1 chunk +6 lines, -6 lines 0 comments Download
M net/cert/x509_util_nss.cc View 2 chunks +25 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ryan Sleevi
3 years, 9 months ago (2017-03-22 18:05:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fc258ccd72adb084aacbabe86a9c1829cc8217f.

Powered by Google App Engine
This is Rietveld 408576698