Add missing .h files to .gn files that have a .cc file next to it in the gn file already.

Add missing .h files to .gn files that have a .cc file next to it in the gn file already.

I downloaded https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2770693003
Cr-Commit-Position: refs/heads/master@{#459147}
Committed: https://chromium.googlesource.com/chromium/src/+/b8590c94fe271ff8b6825fd703c6c9ff6e2429ab

[Nico, 2017-03-23 14:12:24]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Nico, 2017-03-23 14:12:28]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-23 14:12:29]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-23 14:12:30]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-23 14:12:39]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 14:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-23 14:12:58]

thakis@chromium.org changed reviewers:
+ tzik@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:17:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:17:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2017-03-23 14:21:48]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 14:22:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 14:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 14:26:17]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2017-03-23 14:54:50]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 14:55:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-23 14:59:18]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2017-03-23 15:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 15:02:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Nico, 2017-03-23 15:11:10]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 15:11:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-23 15:39:11]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 15:39:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-23 15:39:56]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2017-03-23 15:39:57]

Brett, can you review this? It's fairly simple, gn-related, and needs global
approval (or a hundred sub-OWNERS).

[tzik, 2017-03-23 15:58:23]

LGTM!

[Nico, 2017-03-23 16:00:06]

On 2017/03/23 15:58:23, tzik wrote:
> LGTM!

Thanks, didn't expect you to still be around at this time :-)

Brett, I'll TBR you.

[Nico, 2017-03-23 16:00:20]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
==========

[Nico, 2017-03-23 16:00:54]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-03-23 16:01:05]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:02:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:16:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-23 17:25:23]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
NOTRY=true
==========

[Nico, 2017-03-23 17:25:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:26:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:34:15]

Failed to apply patch for content/test/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: content/test/BUILD.gn:40
  error: content/test/BUILD.gn: patch does not apply

Patch:       content/test/BUILD.gn
Index: content/test/BUILD.gn
diff --git a/content/test/BUILD.gn b/content/test/BUILD.gn
index
f5aefba94965ceccb78629714c0ba707f4a8a180..3c6d482e93014d3d236be22a9923b1fbec395c1b
100644
--- a/content/test/BUILD.gn
+++ b/content/test/BUILD.gn
@@ -40,6 +40,7 @@ static_library("test_support") {
     "../browser/service_worker/embedded_worker_test_helper.cc",
     "../browser/service_worker/embedded_worker_test_helper.h",
     "../browser/service_worker/service_worker_test_utils.cc",
+    "../browser/service_worker/service_worker_test_utils.h",
     "../public/test/async_file_test_helper.cc",
     "../public/test/async_file_test_helper.h",
     "../public/test/background_sync_test_util.cc",
@@ -928,7 +929,9 @@ test("content_browsertests") {
   if (enable_plugins) {
     sources += [
       "../renderer/pepper/fake_pepper_plugin_instance.cc",
+      "../renderer/pepper/fake_pepper_plugin_instance.h",
       "../renderer/pepper/mock_renderer_ppapi_host.cc",
+      "../renderer/pepper/mock_renderer_ppapi_host.h",
       "../renderer/pepper/pepper_device_enumeration_host_helper_unittest.cc",
       "../renderer/pepper/pepper_file_chooser_host_unittest.cc",
       "../renderer/pepper/pepper_graphics_2d_host_unittest.cc",
@@ -1618,6 +1621,7 @@ test("content_unittests") {
       "../renderer/media/media_stream_video_source_unittest.cc",
       "../renderer/media/media_stream_video_track_unittest.cc",
       "../renderer/media/mock_constraint_factory.cc",
+      "../renderer/media/mock_constraint_factory.h",
       "../renderer/media/mock_media_stream_registry.cc",
       "../renderer/media/mock_media_stream_registry.h",
       "../renderer/media/mock_media_stream_video_sink.cc",

[Nico, 2017-03-23 17:37:34]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
NOTRY=true
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
==========

[Nico, 2017-03-23 17:37:41]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-23 17:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2770693003/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-23 17:38:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-03-23 17:47:20]

spot-checked LGTM

[Nico, 2017-03-23 17:53:18]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brettw
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2017-03-23 17:53:48]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
==========

[Nico, 2017-03-23 17:53:57]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-03-23 18:01:26]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:02:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:14:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490292086434490,
"parent_rev": "e867cc9b0a3e47744a2233e919a54dd37d57b641", "commit_rev":
"b8590c94fe271ff8b6825fd703c6c9ff6e2429ab"}

[commit-bot: I haz the power, 2017-03-23 18:15:42]

Description was changed from

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
==========

to

==========
Add missing .h files to .gn files that have a .cc file next to it in the gn file
already.

I downloaded
https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...
as a csv file, and removed the header line and all columns except the filename.
Then i ran this script to create this CL:

    import os, re, subprocess
    edits = {}
    for filename in open('/Users/thakis/Downloads/files.txt'):
      filename = filename.strip()
      if not filename.endswith('.h'):
	continue
      basename = os.path.basename(filename)
      cc = r'\b' + os.path.splitext(basename)[0] + r'\.(cc|cpp|mm)\b'
      p = subprocess.Popen(['git', 'grep', '-En', cc, '--', '*.gn', '*.gni'],
			   stdout = subprocess.PIPE)
      out, _ = p.communicate()
      if p.returncode != 0 or not out:
	continue

      for gnline in out.splitlines():
	gnfile, linenr, contents = gnline.split(':')
	linenr = int(linenr)
	new = re.sub(cc, basename, contents)
	print gnfile, linenr, new
	edits.setdefault(gnfile, {})[linenr] = new

    for gnfile in edits:
      lines = open(gnfile).read().splitlines()
      for l in reversed(edits[gnfile].keys()):
	lines.insert(l, edits[gnfile][l])
      open(gnfile, 'w').write('\n'.join(lines))


(It has off-by-a-few errors in the insertion code, so I manually cleaned up
the output a little bit. Since it was only needed in two files, I didn't
debug the script.)

I then removed the editing part of the script and made it just do `if out: print
filename` at the end of the
first loop, and used this Apps Script to updated the spreadsheet:

    var covered = [ /* filenames printed by script */ ];
    function thakisAutoScript() {
      var spreadsheet = SpreadsheetApp.getActive();
      var sheet = spreadsheet.getActiveSheet();
      var dataRange = sheet.getRange("A2:E898");
      var data = dataRange.getValues();
      for (var i = 0; i < data.length; ++i) {
        var row = data[i];
        var file = row[0];
        if (covered.indexOf(file) == -1)
          continue;
        row[1] = '.h';
        row[2] = 'FALSE';
        row[3] = 'thakis';
        row[4] = 'https://codereview.chromium.org/2770693003/';
        sheet.getRange(2 + i, 1, 1, 5).setValues([row]);
      }
    }

No intended behavior change, see "[chromium-dev] Unlisted source files in
BUILD.gn"

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2770693003
Cr-Commit-Position: refs/heads/master@{#459147}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8590c94fe271ff8b6825fd703c6...
==========

[commit-bot: I haz the power, 2017-03-23 18:15:46]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/b8590c94fe271ff8b6825fd703c6...