Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2770683003: [DevTools] Fix Popover click handling. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix Popover click handling. We used to not hide old popover when clicking to show new one, now we do. BUG=704022 Review-Url: https://codereview.chromium.org/2770683003 Cr-Commit-Position: refs/heads/master@{#458972} Committed: https://chromium.googlesource.com/chromium/src/+/5786cea1a61ebae48b4635bf89544038f9fa4455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 4 chunks +17 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
dgozman
Take a look please.
3 years, 9 months ago (2017-03-22 23:00:54 UTC) #3
lushnikov
lgtm
3 years, 9 months ago (2017-03-23 00:24:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770683003/1
3 years, 9 months ago (2017-03-23 00:31:27 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 01:42:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5786cea1a61ebae48b4635bf8954...

Powered by Google App Engine
This is Rietveld 408576698