Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: ios/web_view/internal/BUILD.gn

Issue 2770633002: Export all CWV* symbols from the ios/web_view dynamic library. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/BUILD.gn
diff --git a/ios/web_view/internal/BUILD.gn b/ios/web_view/internal/BUILD.gn
index 444aedad5d739b9c8db3248843b99e6a402ff6b1..3cf407933c3609de5117b91b8172305b1fd4d2fc 100644
--- a/ios/web_view/internal/BUILD.gn
+++ b/ios/web_view/internal/BUILD.gn
@@ -36,6 +36,9 @@ source_set("internal") {
"web_view_web_state_policy_decider.h",
"web_view_web_state_policy_decider.mm",
]
+
+ defines = [ "CWV_IMPLEMENTATION" ]
michaeldo 2017/03/22 23:16:22 Can you explain what this is for, probably should
Hiroshi Ichikawa 2017/03/23 05:03:02 Added a description to the CL. Also added a short
michaeldo 2017/03/23 15:12:41 Understand now, thank you!
+
deps = [
"//base",
"//components/pref_registry",

Powered by Google App Engine
This is Rietveld 408576698