Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2770623002: Error in JSTests.json prevented uploads. (Closed)

Created:
3 years, 9 months ago by mvstanton
Modified:
3 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Error in JSTests.json prevented uploads. TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2770623002 Cr-Commit-Position: refs/heads/master@{#44003} Committed: https://chromium.googlesource.com/v8/v8/+/da511d3349fbc5f1cbaea804f3082aa2dbf1fe4d

Patch Set 1 #

Patch Set 2 : Missed one! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/js-perf-test/JSTests.json View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770623002/20001
3 years, 9 months ago (2017-03-22 09:07:41 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/da511d3349fbc5f1cbaea804f3082aa2dbf1fe4d
3 years, 9 months ago (2017-03-22 09:07:54 UTC) #6
Michael Achenbach
3 years, 9 months ago (2017-03-22 10:30:14 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698