[Mac] Change the notification button drop down label

[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056, 703746
Review-Url: https://codereview.chromium.org/2770523003
Cr-Commit-Position: refs/heads/master@{#458891}
Committed: https://chromium.googlesource.com/chromium/src/+/6b033f1a96a84d279e687dc86054d4491e33d64a

[Miguel Garcia, 2017-03-22 12:56:38]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[Miguel Garcia, 2017-03-22 12:56:52]

Description was changed from

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=
==========

to

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056
==========

[commit-bot: I haz the power, 2017-03-22 12:57:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2017-03-22 12:57:53]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Miguel Garcia, 2017-03-22 12:59:21]

Description was changed from

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056
==========

to

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056,703746
==========

[commit-bot: I haz the power, 2017-03-22 13:41:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:41:47]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-03-22 14:35:25]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2017-03-22 14:35:25]

lgtm

https://codereview.chromium.org/2770523003/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2770523003/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:182:
base::scoped_nsobject<NotificationBuilder> builder([
Silly clang-format?

[Peter Beverloo, 2017-03-22 14:52:53]

lgtm

https://codereview.chromium.org/2770523003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2770523003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11508: +      <message
name="IDS_NOTIFICATION_BUTTON_MORE" desc="Button label to display more options
like extra buttons or going to the site settings page.">
nit: I'd use this opportunity to better specify the intended usage and
restrictions, since it's quite specific. What about:

"Label shown on the second button of a Mac OX S system notification used to
expand further options. [CHAR-LIMIT=12]"

[Miguel Garcia, 2017-03-22 20:45:58]

https://codereview.chromium.org/2770523003/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2770523003/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11508: +      <message
name="IDS_NOTIFICATION_BUTTON_MORE" desc="Button label to display more options
like extra buttons or going to the site settings page.">
On 2017/03/22 14:52:53, Peter Beverloo wrote:
> nit: I'd use this opportunity to better specify the intended usage and
> restrictions, since it's quite specific. What about:
> 
> "Label shown on the second button of a Mac OX S system notification used to
> expand further options. [CHAR-LIMIT=12]"

Done.

https://codereview.chromium.org/2770523003/diff/1/chrome/browser/notification...
File chrome/browser/notifications/notification_platform_bridge_mac.mm (right):

https://codereview.chromium.org/2770523003/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:182:
base::scoped_nsobject<NotificationBuilder> builder([
On 2017/03/22 14:35:25, Robert Sesek wrote:
> Silly clang-format?

Yes in fact I had to bypass it because it kept insisting in changing it.

https://codereview.chromium.org/2770523003/diff/1/chrome/browser/notification...
chrome/browser/notifications/notification_platform_bridge_mac.mm:182:
base::scoped_nsobject<NotificationBuilder> builder([
On 2017/03/22 14:35:25, Robert Sesek wrote:
> Silly clang-format?

Yes in fact I had to bypass it because it kept insisting in changing it.

[Miguel Garcia, 2017-03-22 20:46:05]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-03-22 20:46:05]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2770523003/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2017-03-22 20:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 22:10:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490215565036120,
"parent_rev": "459626a30e98698858483dba3605d5e8021df8ec", "commit_rev":
"6b033f1a96a84d279e687dc86054d4491e33d64a"}

[commit-bot: I haz the power, 2017-03-22 22:11:16]

Description was changed from

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056,703746
==========

to

==========
[Mac] Change the notification button drop down label

Change the text from "Options" to "More" as per UX guidelines

BUG=571056,703746

Review-Url: https://codereview.chromium.org/2770523003
Cr-Commit-Position: refs/heads/master@{#458891}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b033f1a96a84d279e687dc86054...
==========

[commit-bot: I haz the power, 2017-03-22 22:11:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b033f1a96a84d279e687dc86054...