chrome/browser/autofill/autofill_browsertest.cc - Issue 277043002: Revert "Revert of [Autofill] Enable Autofill for dynamically created forms. (https://codereview.chr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 277043002: Revert "Revert of [Autofill] Enable Autofill for dynamically created forms. (https://codereview.chr… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix form_structure_browsertests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/autofill_browsertest.cc

diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc

index f79965ee1a0c8904aa20f181aaf214b0fcf36c06..0bb9f60dd87cfb4a36cdf19d1e91327abd6d7619 100644

--- a/chrome/browser/autofill/autofill_browsertest.cc

+++ b/chrome/browser/autofill/autofill_browsertest.cc

@@ -162,7 +162,10 @@ class AutofillTest : public InProcessBrowserTest {

// The function returns after the PersonalDataManager is updated.

void FillFormAndSubmit(const std::string& filename, const FormMap& data) {

GURL url = test_server()->GetURL("files/autofill/" + filename);

- ui_test_utils::NavigateToURL(browser(), url);

+ chrome::NavigateParams params(browser(), url,

+ content::PAGE_TRANSITION_LINK);

+ params.disposition = NEW_FOREGROUND_TAB;

+ ui_test_utils::NavigateToURL(&params);

std::string js;

for (FormMap::const_iterator i = data.begin(); i != data.end(); ++i) {

« no previous file with comments | « no previous file | chrome/renderer/autofill/autofill_renderer_browsertest.cc » ('j') | components/autofill/content/renderer/autofill_agent.cc » ('J')