Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2881)

Unified Diff: chrome/browser/permissions/permission_request_manager_browsertest.cc

Issue 2770423002: Do not show permission bubble when browser is not active (Closed)
Patch Set: BrowserListObserver Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_manager_browsertest.cc
diff --git a/chrome/browser/permissions/permission_request_manager_browsertest.cc b/chrome/browser/permissions/permission_request_manager_browsertest.cc
index c59adcda93a7d1d26bfae3757a29eacb542818d7..5c30fb4d9562ad5f149f1dd79cf6ff7c219eb31b 100644
--- a/chrome/browser/permissions/permission_request_manager_browsertest.cc
+++ b/chrome/browser/permissions/permission_request_manager_browsertest.cc
@@ -300,6 +300,30 @@ IN_PROC_BROWSER_TEST_F(PermissionRequestManagerBrowserTest,
EXPECT_EQ(1, bubble_factory()->total_request_count());
}
+// Tests that the permission bubble should only show on active browser
+// (crbug.com/704350).
+IN_PROC_BROWSER_TEST_F(PermissionRequestManagerBrowserTest,
+ ShowPromptOnActiveBrowser) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ // Simulate a native widget deactivation for browser().
+ BrowserList::GetInstance()->NotifyBrowserNoLongerActive(browser());
Qiang(Joe) Xu 2017/03/27 21:09:52 This is a work around for testing this, otherwise
+ ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
+ browser(),
+ embedded_test_server()->GetURL(
+ "/permissions/requests-before-after-load.html"),
+ 1);
+ bubble_factory()->WaitForPermissionBubble();
+
+ EXPECT_EQ(0, bubble_factory()->show_count());
+ EXPECT_EQ(0, bubble_factory()->total_request_count());
+
+ BrowserList::GetInstance()->SetLastActive(browser());
+ bubble_factory()->WaitForPermissionBubble();
+ EXPECT_EQ(1, bubble_factory()->show_count());
+ EXPECT_EQ(1, bubble_factory()->total_request_count());
+}
+
// Navigating twice to the same URL should be equivalent to refresh. This means
// showing the bubbles twice.
// http://crbug.com/512849 flaky

Powered by Google App Engine
This is Rietveld 408576698