chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc - Issue 2770423002: Do not show permission bubble when browser is not active

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc

Issue 2770423002: Do not show permission bubble when browser is not active (Closed)

Patch Set: BrowserListObserver Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_request_manager_browsertest.cc ('K') | « chrome/browser/permissions/permission_request_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc

diff --git a/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc b/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc

index 11a96b40d27d7af7ad5507063eb437e7eb646d13..f8de6f47420a2ac8d851eaefc80e9a15fdf251f3 100644

--- a/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc

+++ b/chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.cc

@@ -64,7 +64,7 @@ bool MockPermissionPromptFactory::is_visible() {

}

void MockPermissionPromptFactory::WaitForPermissionBubble() {

- if (is_visible())

+ if (is_visible() || !manager_->browser_active_)

return;

DCHECK(show_bubble_quit_closure_.is_null());

base::RunLoop loop;