Chromium Code Reviews| Index: chrome/browser/permissions/permission_request_manager_browsertest.cc |
| diff --git a/chrome/browser/permissions/permission_request_manager_browsertest.cc b/chrome/browser/permissions/permission_request_manager_browsertest.cc |
| index c59adcda93a7d1d26bfae3757a29eacb542818d7..5c30fb4d9562ad5f149f1dd79cf6ff7c219eb31b 100644 |
| --- a/chrome/browser/permissions/permission_request_manager_browsertest.cc |
| +++ b/chrome/browser/permissions/permission_request_manager_browsertest.cc |
| @@ -300,6 +300,30 @@ IN_PROC_BROWSER_TEST_F(PermissionRequestManagerBrowserTest, |
| EXPECT_EQ(1, bubble_factory()->total_request_count()); |
| } |
| +// Tests that the permission bubble should only show on active browser |
| +// (crbug.com/704350). |
| +IN_PROC_BROWSER_TEST_F(PermissionRequestManagerBrowserTest, |
| + ShowPromptOnActiveBrowser) { |
| + ASSERT_TRUE(embedded_test_server()->Start()); |
| + |
| + // Simulate a native widget deactivation for browser(). |
| + BrowserList::GetInstance()->NotifyBrowserNoLongerActive(browser()); |
|
Qiang(Joe) Xu
2017/03/27 21:09:52
This is a work around for testing this, otherwise
|
| + ui_test_utils::NavigateToURLBlockUntilNavigationsComplete( |
| + browser(), |
| + embedded_test_server()->GetURL( |
| + "/permissions/requests-before-after-load.html"), |
| + 1); |
| + bubble_factory()->WaitForPermissionBubble(); |
| + |
| + EXPECT_EQ(0, bubble_factory()->show_count()); |
| + EXPECT_EQ(0, bubble_factory()->total_request_count()); |
| + |
| + BrowserList::GetInstance()->SetLastActive(browser()); |
| + bubble_factory()->WaitForPermissionBubble(); |
| + EXPECT_EQ(1, bubble_factory()->show_count()); |
| + EXPECT_EQ(1, bubble_factory()->total_request_count()); |
| +} |
| + |
| // Navigating twice to the same URL should be equivalent to refresh. This means |
| // showing the bubbles twice. |
| // http://crbug.com/512849 flaky |