Add a type to uniquely identify a Background Fetch

Add a type to uniquely identify a Background Fetch

Each Service Worker Registration may only have one Background Fetch
active for a given tag, and has an associated origin. The new
BackgroundFetchRegistrationId type encapsulates the three values.

TBR=avi (file addition in //c/b/background_fetch/)
BUG=

Review-Url: https://codereview.chromium.org/2770393003
Cr-Commit-Position: refs/heads/master@{#459726}
Committed: https://chromium.googlesource.com/chromium/src/+/6965a1a18751e9c2331051dbe2d986ad392f5250

[Peter Beverloo, 2017-03-25 18:04:13]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 18:04:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-03-25 18:06:02]

peter@chromium.org changed reviewers:
+ harkness@chromium.org

[Peter Beverloo, 2017-03-25 18:06:04]

This peels away the identification bits from BackgroundFetchJobInfo. It's sole
purpose is to identify a certain Background Fetch registration in scope of a
profile. We can move further by adding the ability to serialize and deserialize
this type to and from a string, which will supersede the GUID.

I haven't updated the BackgroundFetchJobInfo as that'd cause a ton of merge
conflicts with your CL.

[commit-bot: I haz the power, 2017-03-25 19:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 19:05:58]

Dry run: This issue passed the CQ dry run.

[harkness, 2017-03-26 14:47:23]

LGTM % question

https://codereview.chromium.org/2770393003/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_registration_id.h
(right):

https://codereview.chromium.org/2770393003/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_registration_id.h:43:
url::Origin origin_;
Do we need the origin to uniquely identify this? I thought the
service_worker_registration_id and tag would be enough.

[harkness, 2017-03-26 15:40:46]

I may have misunderstood what your goal was with this class. We should talk
offline.

[Peter Beverloo, 2017-03-26 21:51:08]

https://codereview.chromium.org/2770393003/diff/1/content/browser/background_...
File content/browser/background_fetch/background_fetch_registration_id.h
(right):

https://codereview.chromium.org/2770393003/diff/1/content/browser/background_...
content/browser/background_fetch/background_fetch_registration_id.h:43:
url::Origin origin_;
On 2017/03/26 14:47:23, harkness wrote:
> Do we need the origin to uniquely identify this? I thought the
> service_worker_registration_id and tag would be enough. 

Yes, but (a) dispatching events to a Service Worker is more efficient if we know
the origin, and (b) this gives us another layer of protection in case of data
being out of sync when one or more databases corrupt. (E.g. the Service Worker
Database.)

[Peter Beverloo, 2017-03-27 08:02:57]

Description was changed from

==========
Add a type to uniquely identify a Background Fetch

Each Service Worker Registration may only have one Background Fetch
active for a given tag, and has an associated origin. The new
BackgroundFetchRegistrationId type encapsulates the three values.

BUG=
==========

to

==========
Add a type to uniquely identify a Background Fetch

Each Service Worker Registration may only have one Background Fetch
active for a given tag, and has an associated origin. The new
BackgroundFetchRegistrationId type encapsulates the three values.

TBR=avi (file addition in //c/b/background_fetch/)
BUG=
==========

[Peter Beverloo, 2017-03-27 08:03:23]

peter@chromium.org changed reviewers:
+ avi@chromium.org

[Peter Beverloo, 2017-03-27 08:03:24]

Putting on the queue w/ TBR=avi for new files in BUILD.gn

[Peter Beverloo, 2017-03-27 08:03:32]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:59:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490601812130370, "parent_rev":
"a4e860c32d99883c2178a332708e69049307209a", "commit_rev":
"6965a1a18751e9c2331051dbe2d986ad392f5250"}

[commit-bot: I haz the power, 2017-03-27 09:00:44]

Description was changed from

==========
Add a type to uniquely identify a Background Fetch

Each Service Worker Registration may only have one Background Fetch
active for a given tag, and has an associated origin. The new
BackgroundFetchRegistrationId type encapsulates the three values.

TBR=avi (file addition in //c/b/background_fetch/)
BUG=
==========

to

==========
Add a type to uniquely identify a Background Fetch

Each Service Worker Registration may only have one Background Fetch
active for a given tag, and has an associated origin. The new
BackgroundFetchRegistrationId type encapsulates the three values.

TBR=avi (file addition in //c/b/background_fetch/)
BUG=

Review-Url: https://codereview.chromium.org/2770393003
Cr-Commit-Position: refs/heads/master@{#459726}
Committed:
https://chromium.googlesource.com/chromium/src/+/6965a1a18751e9c2331051dbe2d9...
==========

[commit-bot: I haz the power, 2017-03-27 09:00:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6965a1a18751e9c2331051dbe2d9...