Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2770363002: Fix the position of AutofillClient for PasswordAutofillManager when the focused form element is ins… (Closed)

Created:
3 years, 9 months ago by EhsanK
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the position of AutofillClient for PasswordAutofillManager when the focused form element is inside OOPIF When a form element is inside an OOPIF, the coordinates which are sent from renderer are with respect to the WebFrameWidget's coordinates and need to be transformed to root coordinate on the browser side. Without this change the position of the autofill pop-up is incorrect. This CL transforms the element bound to root view's coordinate before showing the autofill pop-up. BUG=686129 Review-Url: https://codereview.chromium.org/2754033002 Cr-Commit-Position: refs/heads/master@{#458593} (cherry picked from commit 6f15a2dc3a3b9bd111352a58c40cf1a1ea0e9652) Review-Url: https://codereview.chromium.org/2770363002 . Cr-Commit-Position: refs/branch-heads/3029@{#414} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/d4ea62753e0609689d9c8de1443ca985f2366e25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -2 lines) Patch
M chrome/browser/chrome_site_per_process_browsertest.cc View 3 chunks +213 lines, -0 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/content/browser/content_password_manager_driver.cc View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
EhsanK
3 years, 9 months ago (2017-03-24 21:06:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d4ea62753e0609689d9c8de1443ca985f2366e25.

Powered by Google App Engine
This is Rietveld 408576698