Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by kozy Modified:
3 years, 8 months ago Reviewers:
dgozman CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype
Current implementation is unsafe if __proto__ getter is defined on Object.prototype.
BUG=chromium:595206
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2770263003
Cr-Commit-Position: refs/heads/master@{#44206}
Committed: https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea445d59c
Patch Set 1 #
Total comments: 1
Patch Set 2 : correct nullifyPrototype usage #
Created: 3 years, 8 months ago
Messages
Total messages: 16 (12 generated)
Dmitry, please take a look. https://codereview.chromium.org/2770263003/diff/1/src/inspector/injected-scri... File src/inspector/injected-script-source.js (right): https://codereview.chromium.org/2770263003/diff/1/src/inspector/injected-scri... src/inspector/injected-script-source.js:1037: var entry = InjectedScriptHost.nullifyPrototype(entries[i]); I couldn't add a test since we return entry with nullified prototype from backend and this call is for more safety only.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2770263003/#ps20001 (title: "correct nullifyPrototype usage")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490726557315360,
"parent_rev": "d7d201d4128f573917c5cef67c8ef3fce63e73bf", "commit_rev":
"c95ef4af70d8c02b48774058141e706ea445d59c"}
Message was sent while issue was closed.
Description was changed from ========== [inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype Current implementation is unsafe if __proto__ getter is defined on Object.prototype. BUG=chromium:595206 R=dgozman@chromium.org ========== to ========== [inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype Current implementation is unsafe if __proto__ getter is defined on Object.prototype. BUG=chromium:595206 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2770263003 Cr-Commit-Position: refs/heads/master@{#44206} Committed: https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea44... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea44... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
