[inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype

[inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype

Current implementation is unsafe if __proto__ getter is defined on Object.prototype.

BUG=chromium:595206
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2770263003
Cr-Commit-Position: refs/heads/master@{#44206}
Committed: https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea445d59c

[kozy, 2017-03-24 20:23:04]

Dmitry, please take a look.

https://codereview.chromium.org/2770263003/diff/1/src/inspector/injected-scri...
File src/inspector/injected-script-source.js (right):

https://codereview.chromium.org/2770263003/diff/1/src/inspector/injected-scri...
src/inspector/injected-script-source.js:1037: var entry =
InjectedScriptHost.nullifyPrototype(entries[i]);
I couldn't add a test since we return entry with nullified prototype from
backend and this call is for more safety only.

[kozy, 2017-03-24 20:23:17]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 20:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:37:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[kozy, 2017-03-26 19:22:35]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 19:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 19:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 19:36:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[dgozman, 2017-03-27 16:41:18]

lgtm

[kozy, 2017-03-28 18:42:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-28 18:42:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2770263003/#ps20001
(title: "correct nullifyPrototype usage")

[commit-bot: I haz the power, 2017-03-28 18:42:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:09:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490726557315360,
"parent_rev": "d7d201d4128f573917c5cef67c8ef3fce63e73bf", "commit_rev":
"c95ef4af70d8c02b48774058141e706ea445d59c"}

[commit-bot: I haz the power, 2017-03-28 19:09:49]

Description was changed from

==========
[inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype

Current implementation is unsafe if __proto__ getter is defined on
Object.prototype.

BUG=chromium:595206
R=dgozman@chromium.org
==========

to

==========
[inspector] nullifyObjectPrototype -> InjectedScriptHost.nullifyPrototype

Current implementation is unsafe if __proto__ getter is defined on
Object.prototype.

BUG=chromium:595206
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2770263003
Cr-Commit-Position: refs/heads/master@{#44206}
Committed:
https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea44...
==========

[commit-bot: I haz the power, 2017-03-28 19:09:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c95ef4af70d8c02b48774058141e706ea44...